refactor(id-cmd): split up id files into multiple files #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On note on this PR. The variables enum is still to big. In plc4x I solved it with this regex |
Closed
|
@sruehl could you rebase your PR and then I'll merge it to v0.6.1. |
sruehl
force-pushed
the
refactor/split_id_gen
branch
2 times, most recently
from
2619f05 to
bc5da56
Compare
sruehl
force-pushed
the
refactor/split_id_gen
branch
from
bc5da56 to
8756c0b
Compare
|
@magiconair rebased |
magiconair
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR spilts up id_gen.go into multiple files
resolves #679