config: bubble up errors from configuration #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current config code has some options which can have errors. The current code calls `log.Fatal` which terminates the application instead of returning the error. The correct solution would be to return the error in ApplyConfig and then return it in NewClient. However, this would break all existing clients. We therefore postpone this breaking change to v0.5.0 when we update the API with breaking changes anyway and in the meantime bubble the error up in the Connect and Dial method. Fixes #616
magiconair
force-pushed
the
issue-616-log-fatal
branch
from
df0381c to
33edbcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current config code has some options which can have errors. The current code calls
log.Fatalwhich terminates the application instead of returning the error.The correct solution would be to return the error in ApplyConfig and then return it in NewClient. However, this would break all existing clients.
We therefore postpone this breaking change to v0.5.0 when we update the API with breaking changes anyway and in the meantime bubble the error up in the Connect and Dial method.
Fixes #616