Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify submux lock #572

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Clarify submux lock #572

merged 3 commits into from
Apr 8, 2022

Conversation

magiconair
Copy link
Member

@magiconair magiconair commented Apr 7, 2022 •
edited
Loading

This patch refactors how we use the subMux lock which guards the subs map and the pendingAcks array. We chose to include the type of lock that is required in the method name as _NeedsSubMuxLock and _NeedsSubMuxRLock.

Closes #563

@magiconair magiconair added this to the v0.3.3 milestone Apr 7, 2022
@magiconair magiconair merged commit 6bb1cf2 into main Apr 8, 2022
@magiconair magiconair deleted the clarify-submux-lock branch April 8, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.3
Development

Successfully merging this pull request may close these issues.
1 participant
@magiconair