Add support for arrays #564
Conversation
|
Don't recall. Can you add a test? |
|
Do we have tests for the encoding part of the library? I can't find them. |
|
|
|
Found it! I also implement the decoding! |
There was a problem hiding this comment.
I think the encode and decode functions can be the same for both slice and array and the type switch can be merged to case reflect.Slice, reflect.Array: to make it obvious. Maybe rename the functions to writeSliceOrArray and similar. The tests will ensure that it works.
Keep error messages consistent and return the upper bound.
There was a problem hiding this comment.
After looking at #566 which merges the functions it became clear that this approach doesn't increase readability. There are too many subtle differences. So we go with separate functions for encoding slices and arrays.
I've found a fast path for byte arrays, updated the tests and made the error messages consistent.
LGTM now
Any reason why this was not implemented?
We have a use case with static size array, and it was returning an error.