move recv() loop from uasc into opcua package #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
May 26, 2019
golangcibot
reviewed
May 27, 2019
|
@dwhutchison does this conflict with #207 ? If not, then we can merge this. |
|
One small optimization could be to create a |
In preparation for a server implmentation, move the main read loop out of the uasc package and allow the caller (client / server) to receive unsolicited uasc messages.
dwhutchison
force-pushed
the
uasc-server-prep
branch
from
fd7c7f1 to
024329a
Compare
|
Force-push just to rebase to master |
|
This should be OK to merge; tests are passing and the examples are functional. |
|
Then lets merge it and move on. |
dwhutchison
added a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a server implementation, move the main read
loop out of the uasc package into the application layer. The primary change is
recv()(renamed toreceive), now returns each time it receives a full message. This allows the caller (client or server) to receive unsolicited uasc messages from the channel.The context can be better seen in https://github.com/gopcua/opcua/tree/feature/server although that code isn't fleshed out enough to merge. The remainder of the server implementation shouldn't have further impact on the uasc package as this change so I'm hoping to get this into the main branch to avoid needing to constantly fix merge conflicts with master.