Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more AddressTypes and AddressComponentTypes #437

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Add more AddressTypes and AddressComponentTypes #437

merged 1 commit into from
Jun 30, 2018

Conversation

apjanke
Copy link
Contributor

@apjanke apjanke commented Jun 29, 2018

This PR adds more currently-unrecognized AddressComponentTypes and AddressTypes.

AddressTypes:

  • general_contractor

AddressComponentTypes:

  • travel_agency
  • electronics_store
  • home_goods_store
  • school
  • store
  • art_gallery
  • lawyer
  • restaurant
  • bar
  • meal_takeaway
  • clothing_store
  • local_government_office
  • finance
  • moving_company
  • storage

These were discovered using my gmsj-cli fuzz tester.

$ ./bin/gmsj-cli geofuzz "555 Broadway, New York, NY" -n 5000 -S 123456                                                                                           master
Searching 5000 points around '555 Broadway, New York, NY', with radius 0.100000 degrees (rand seed 123456)
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressComponentType: 'real_estate_agency'
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressComponentType: 'travel_agency'
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressComponentType: 'real_estate_agency'
[main] WARN com.google.maps.internal.SafeEnumAdapter - Unknown type for enum com.google.maps.model.AddressComponentType: 'travel_agency'
[...]

@domesticmouse
Copy link
Contributor

I get the feeling I am going to break your PRs each time I merge one. Do you want to collapse all the location type addition PRs into a single PR?

@apjanke
Copy link
Contributor Author

apjanke commented Jun 30, 2018

Sure.

I have merged all my outstanding location type PRs into this one, and rebased it on master. Looks like the merge is clean now.

@apjanke
Copy link
Contributor Author

apjanke commented Jun 30, 2018

Hold on, don't merge this yet: got a failing unit test in com.google.maps.model.EnumsTest. Fixing...

AddressTypes:
* general_contractor

AddressComponentTypes:
* travel_agency
* electronics_store
* home_goods_store
* school
* store
* art_gallery
* lawyer
* restaurant
* bar
* meal_takeaway
* clothing_store
* local_government_office
* finance
* moving_company
* storage
* cafe
* car_repair
* health
* insurance_agency
* painter
@apjanke
Copy link
Contributor Author

apjanke commented Jun 30, 2018

Unit test is fixed (including a fix for the failure introduced by #436). This is good to merge now, I think.

@domesticmouse domesticmouse merged commit d0d9010 into googlemaps:master Jun 30, 2018
@domesticmouse
Copy link
Contributor

Thanks!

@apjanke apjanke deleted the more-location-types-3 branch June 30, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants