Add extra safety to unmarshaling to enums. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param unknownValue the value to return if the value cannot be found. | ||
| */ | ||
| public SafeEnumAdapter(E unknownValue) { | ||
| if (unknownValue == null) throw new IllegalArgumentException(); |
There was a problem hiding this comment.
Cheeky. The style guide says no (but I say yes).
|
|
|
lgtm |
Removes existing TravelModeAdapter, AddressTypeAdapter and AddressComponentTypeAdapter, replaces them with generic SafeEnumAdapter. Add tests that check converting UNKNOWN to a UrlValue throws an exception.
broady
added a commit
that referenced
this pull request
Oct 3, 2014
Add extra safety to unmarshaling to enums.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes existing TravelModeAdapter, AddressTypeAdapter and AddressComponentTypeAdapter, replaces them with generic SafeEnumAdapter.
Add tests that check converting UNKNOWN to a UrlValue throws an exception.