Fix problems found trying to build color-fonts repo updates #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For some reason importlib.resources fails to acknowledge our resources on 3.9 while importlib_resources works as expected. |
rsheeter
changed the title
rsheeter
changed the title
rsheeter
commented
Nov 25, 2020
anthrotype
approved these changes
Nov 25, 2020
| @@ -327,8 +327,7 @@ def _add_glyph(svg: SVG, color_glyph: ColorGlyph, reuse_cache: ReuseCache): | |||
| svg_use.attrib["y"] = _ntos(ty) | |||
| transform = reuse.translate(-tx, -ty) | |||
| if transform != Affine2D.identity(): | |||
| # TODO apply scale and rotation. Just slap a transform on the <use>? | |||
| raise NotImplementedError("TODO apply scale & rotation to use") | |||
| svg_use.attrib["transform"] = _svg_matrix(transform) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers issues encountered trying to update https://github.com/googlefonts/color-fonts using python 3.9, adding tests where possible. Notably we had stopped using picosvgs and untouchedsvg wasn't working very well.
Fixes #196.