test: add downstream check for spring-cloud-gcp #3092
Conversation
|
Using our custom Removing the following line for now: @blakeli0 maybe you can help me understand why our Google mirror doesn't have this dependency? |
|
LGTM |
Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>
|
|
||
|
|
||
| # Generate showcase autoconfig | ||
| bash scripts/generate-showcase.sh |
There was a problem hiding this comment.
Can we just do ./scripts/generate-showcase.sh?
| # Download and configure spring-cloud-gcp for testing | ||
| last_release=$(find_last_release_version "spring-cloud-gcp" "main" "GoogleCloudPlatform") | ||
| git clone "https://github.com/GoogleCloudPlatform/spring-cloud-gcp.git" --depth=1 --branch "v$last_release" | ||
| update_all_poms_dependency "spring-cloud-gcp" "gapic-generator-java-bom" "${GAPIC_GENERATOR_VERSION}" |
There was a problem hiding this comment.
@lqiu96 This update_all_poms_dependency looks like a nice util that maybe we can reuse in testing protoc.
There was a problem hiding this comment.
The script I wrote to update the poms is pretty much a copy of this implementation. When I originally wrote it, I had the limitation where i couldn't use xmllint or xmlstartlet in kokoro.
Co-authored-by: Burke Davison <40617934+burkedavison@users.noreply.github.com>
diegomarquezp
added
the
automerge
|
|
gcf-merge-on-green
bot
removed
the
automerge
Fixes https://github.com/googleapis/sdk-platform-java/issues/2534 The check takes 2 minutes
Fixes #2534
The check takes 2 minutes