Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add HW repo templates #2884

Merged
merged 1 commit into from
Jun 13, 2024
Merged

chore: add HW repo templates #2884

merged 1 commit into from
Jun 13, 2024

Conversation

diegomarquezp
Copy link
Contributor

@diegomarquezp diegomarquezp commented Jun 12, 2024

In this PR we add the .github and .kokoro folders to
library_generation/owlbot/templates/java_library in order to enable
the hermetic build workflows in HW libraries.

The templates come from googleapis/synthtool@dae1282

The hermetic build templates will come in a separate PR

In this PR we add the `.github` and `.kokoro` folders to
`library_generation/owlbot/templates/java_library` in order to enable
the hermetic build workflows in HW libraries
@diegomarquezp diegomarquezp requested a review from a team as a code owner June 12, 2024 17:05
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 12, 2024
Copy link
Collaborator

@JoeWang1127 JoeWang1127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you update the action version to latest stable version?

Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@diegomarquezp
Copy link
Contributor Author

nit: could you update the action version to latest stable version?

@JoeWang1127
Latest versions:

No updates were needed

@blakeli0 blakeli0 requested a review from suztomo June 12, 2024 22:22
@diegomarquezp diegomarquezp merged commit d567453 into main Jun 13, 2024
34 checks passed
@diegomarquezp diegomarquezp deleted the add-hw-templates branch June 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants