Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): add detector-resource-support dependencies #2559

Merged
merged 6 commits into from
Mar 15, 2024
Merged

fix(deps): add detector-resource-support dependencies #2559

merged 6 commits into from
Mar 15, 2024

Conversation

mutianf
Copy link
Contributor

@mutianf mutianf commented Mar 13, 2024

b/329410901

@mutianf mutianf requested a review from a team as a code owner March 13, 2024 13:37
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 13, 2024
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 13, 2024
blakeli0
blakeli0 reviewed Mar 13, 2024
View reviewed changes
java-shared-dependencies/third-party-dependencies/pom.xml Outdated
@@ -184,13 +185,15 @@
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-api</artifactId>
<artifactId>opentelemetry-bom</artifactId>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mutianf, we plan to merge our own Otel PR as well in this cycle, and it includes the bom, do you think it would cover your use case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Yes! I do also need the other detector-resources-support dependency though. Do you think you can also add that in your PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't use detector-resources-support, I think it's better to leave it in this PR. I'll let you know once we merged our Otel PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mutianf The PR is merged now, do you mind modifying this PR accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated! However I noticed that the open telemetry version in shared-dependencies pom is already 1.36.0 but in gax it was still 1.35.0. I think we should update the version in gax :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenTelemetry version in Gax should come from the same opentelemetry.version property, where did you find that it is still 1.35.0? In addition, I think we might be able to remove opentelemetry-bom section from this pom because it is already declared in Gax?

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Mar 15, 2024
@blakeli0
Copy link
Collaborator

/gcbrun

@blakeli0 blakeli0 changed the title chore: add opentelemetry-bom and detector-resource-support dependencies chore: add detector-resource-support dependencies Mar 15, 2024
@blakeli0 blakeli0 changed the title chore: add detector-resource-support dependencies fix(deps): add detector-resource-support dependencies Mar 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@diegomarquezp diegomarquezp enabled auto-merge (squash) March 15, 2024 17:42
@blakeli0 blakeli0 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 15, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 15, 2024
@diegomarquezp diegomarquezp merged commit 53f2c85 into googleapis:main Mar 15, 2024
40 of 42 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 15, 2024
@release-please release-please bot mentioned this pull request Mar 15, 2024
Merged
@mutianf mutianf deleted the add-dependency branch March 15, 2024 21:43
diegomarquezp pushed a commit that referenced this pull request Mar 15, 2024
@release-please @blakeli0
chore(main): release 2.38.1 (#2581)
6dee917 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.38.1</summary>

##
[2.38.1](v2.38.0...v2.38.1)
(2024-03-15)


### Bug Fixes

* **deps:** add detector-resource-support dependencies
([#2559](#2559))
([53f2c85](53f2c85))
* Update shopping and chat common protos.
([#2580](#2580))
([f472756](f472756))


### Dependencies

* update google api dependencies
([#2582](#2582))
([dd03d93](dd03d93))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Blake Li <blakeli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mutianf @blakeli0 @suztomo @diegomarquezp