chore: re-enable HW processing for hermetic build scripts #2505
Conversation
diegomarquezp
changed the title
…ild-for-hw-libs' into restore-hermetic-build-for-hw-libs
…bs' into restore-hermetic-build-for-hw-libs
product-auto-label
bot
added
size: l
Done |
…bs' into restore-hermetic-build-for-hw-libs
| "repo_short": "java-bare-metal-solution", | ||
| "distribution_name": "com.google.cloud:google-cloud-bare-metal-solution", | ||
| "api_id": "baremetalsolution.googleapis.com", | ||
| "library_type": "GAPIC_AUTO", |
There was a problem hiding this comment.
Do we need to change this value to GAPIC_COMBO?
There was a problem hiding this comment.
note: Just hardcode it in the test
library_generation/generate_repo.py
Outdated
| @@ -102,6 +108,11 @@ def generate_from_yaml( | |||
| versions_file=repo_config.versions_file, | |||
| ) | |||
|
|
|||
| # we skip repo_level_postprocess if not in a monorepo since it's meant for | |||
There was a problem hiding this comment.
I know it was not introduced in this PR, can we rename repo_level_postprocess to monorepo_postprocess if it's meant for monorepo only?
There was a problem hiding this comment.
Agreed. Renamed to monorepo_postprocessing
| @@ -46,6 +46,7 @@ def __init__( | |||
| rpc_documentation: Optional[str] = None, | |||
| cloud_api: Optional[bool] = True, | |||
| requires_billing: Optional[bool] = True, | |||
| extra_versioned_modules: Optional[str] = None, | |||
There was a problem hiding this comment.
@diegomarquezp Going forward, I'm not sure accommodating every non-standard field in repo-metadata.json in our scripts is the way to go, we may want to leave the responsibility to each handwritten library owner. For now, can you please document this new parameter in go/java-hermetic-build-config-spec?
| @@ -14,5 +14,6 @@ | |||
| "library_type": "GAPIC_AUTO", | |||
| "requires_billing": true, | |||
| "rest_documentation": "https://cloud.google.com/bare-metal/docs/reference/rest", | |||
| "rpc_documentation": "https://cloud.google.com/bare-metal/docs/reference/rpc" | |||
| "rpc_documentation": "https://cloud.google.com/bare-metal/docs/reference/rpc", | |||
| "extra_versioned_modules": "test-module" | |||
There was a problem hiding this comment.
This parameter should not be in monorepo goldens. Do google-cloud-java and java-bigtable share the same test setup?
There was a problem hiding this comment.
I treated this repo-metadata entry as monorepo-agnostic, but I agree it's closer to real life to not include it here. I removed it and adapted the test accordingly.
|
|
re-enables the changes from #2342 as part of milestone 3.2 of Hermetic Build
Changes:
integration_tests.pyfix-poms.pyto use monorepo and split_repo modesgenerate_composed_library.pyin order to avoid collisionsgoogle/bigtable/v2andgoogle/bigtable/admin/v2would both be sent to a temporaljava-bigtable-v2folder, spoiling the files being transferred viacopy-code.proto_path-based folder name to achieve uniquenessAfter this PR: