Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor new-client.py #2422

Closed
wants to merge 1 commit into from
Closed

chore: refactor new-client.py #2422

wants to merge 1 commit into from

Conversation

JoeWang1127
Copy link
Collaborator

In this PR:

  • Rename new-client.py to generate_repo.py
  • Split repo-level post processing to a dedicated script (repo_level_post_processor.py).

This is part of milestone 2 of hermetic build project.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jan 25, 2024
@JoeWang1127 JoeWang1127 marked this pull request as ready for review January 25, 2024 19:57
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner January 25, 2024 19:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 requested a review from blakeli0 January 25, 2024 20:16
blakeli0
blakeli0 reviewed Jan 25, 2024
View reviewed changes
library_generation/repo_generation/repo_level_post_processor.py
from pathlib import Path


def repo_level_post_process(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we write unit tests for new Python scripts if possible?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to what @diegomarquezp did in his PR

Copy link
Collaborator Author

@JoeWang1127 JoeWang1127 Jan 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I add unit tests after #2342 is merged since the python unit test infrastructure is setup in that PR.

Also, I still need another PR to refactor generate_repo.py and I'll include more unit tests and integration tests in that PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeWang1127 I added a few units for ClientInputs in #2342

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I'm moving ClientInputs to library_generation/model since it defines a structural class. Better wait for mine to get merged

@JoeWang1127
Copy link
Collaborator Author

Absolved by #2431

@JoeWang1127 JoeWang1127 closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeli0 blakeli0 blakeli0 left review comments

@diegomarquezp diegomarquezp diegomarquezp left review comments

Assignees
No one assigned
Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @blakeli0 @diegomarquezp