Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added retry and timeout params to partition read in database and snapshot class #278

Merged
merged 7 commits into from
Mar 24, 2021
Merged

feat: added retry and timeout params to partition read in database and snapshot class #278

merged 7 commits into from
Mar 24, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented Mar 16, 2021

Added retry and timeout params to partition read in database and snapshot class

Fixes #71 🦕

@vi3k6i5 vi3k6i5 requested a review from larkee March 16, 2021 18:00
@vi3k6i5 vi3k6i5 requested a review from a team as a code owner March 16, 2021 18:00
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Mar 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2021
larkee
larkee reviewed Mar 17, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far 👍

generate_read_batches and generate_query_batches both generate partitions which are then used with process_read_batch and process_query_batch respectively. Please also add the options to these methods to complete the support

@larkee larkee linked an issue Mar 17, 2021 that may be closed by this pull request
Add custom retry and timeout options for partition reads and queries #261
Closed
@vi3k6i5
Copy link
Contributor Author

vi3k6i5 commented Mar 18, 2021

@larkee : made the change.

@vi3k6i5 vi3k6i5 requested review from larkee, thiagotnunes, a team and skuruppu March 18, 2021 11:43
larkee
larkee reviewed Mar 22, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some minor test nits

@vi3k6i5 vi3k6i5 requested a review from larkee March 23, 2021 13:14
larkee
larkee approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@larkee larkee merged commit 1a7c9d2 into googleapis:master Mar 24, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 25, 2021
@release-please
chore: release 3.3.0 (#263)
6b517f2 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.3.0](https://github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25)


### Features

* add encryption_info to Database ([#284](https://github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435))
* add support for CMEK ([#105](https://github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0))
* add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d))
* added retry and timeout params to partition read in database and snapshot class ([#278](https://github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f))
* **db_api:** support executing several DDLs separated by semicolon ([#277](https://github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8))


### Bug Fixes

* avoid consuming pending null values when merging ([#286](https://github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b))
* **db_api:** allow file path for credentials ([#221](https://github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a))
* **db_api:** ensure DDL statements are being executed ([#290](https://github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f))
* **db_api:** revert Mutations API usage ([#285](https://github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c))


### Documentation

* fix docstring types and typos ([#259](https://github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c))
* fix snapshot usage ([#291](https://github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@thiagotnunes thiagotnunes Awaiting requested review from thiagotnunes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
2 participants
@vi3k6i5 @larkee