Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: deprecate AppEngineHandler and ContainerEngineHandler #202

Closed
daniel-sanche opened this issue Mar 2, 2021 · 0 comments
Closed

feat!: deprecate AppEngineHandler and ContainerEngineHandler #202

daniel-sanche opened this issue Mar 2, 2021 · 0 comments
Assignees
@daniel-sanche
Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Milestone
v3.0.0 Breaking

Comments

@daniel-sanche
Copy link
Contributor

The library originally made unique handlers for each environment. This doesn't scale well as GCP continues to add environments, especially since (other than the MonitoredResource) most of the code is shared.

As part of the breaking update, we should consider removing the legacy handlers and refactoring
@daniel-sanche daniel-sanche added this to the v3.0.0 Breaking milestone Mar 2, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Mar 2, 2021
@daniel-sanche daniel-sanche self-assigned this Mar 2, 2021
@daniel-sanche daniel-sanche added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Mar 2, 2021
snarfed added a commit to snarfed/webutil that referenced this issue Mar 6, 2021
@snarfed
appengine_config: logging: manually find and inject Google Cloud trac…
38eaafc 
…e id

makes log lines attach to their HTTP request and show grouped in cloud console log browser. google-cloud-logging used to do this automatically for webapp2, based on the X-Cloud-Trace-Context header, but it dropped webapp2 as of google-cloud-logging 2.0.

background:
googleapis/python-logging#110 (comment)
googleapis/python-logging#149 (comment)

also note that AppEngineHandler is evidently deprecated, so I may need to port that whole class into webutil eventually. :(
googleapis/python-logging#202
This was referenced May 13, 2021
Closed
Closed
@daniel-sanche daniel-sanche mentioned this issue May 27, 2021
Merged
@daniel-sanche daniel-sanche changed the title feat!: remove AppEngineHandler and ContainerEngineHandler feat!: deprecate AppEngineHandler and ContainerEngineHandler Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
v3.0.0 Breaking
Development

No branches or pull requests
1 participant
@daniel-sanche