Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong description of expiration_time field of File type #318

Closed
mikonapoli opened this issue Feb 12, 2025 · 0 comments · Fixed by #322 or #307
Closed

Wrong description of expiration_time field of File type #318

mikonapoli opened this issue Feb 12, 2025 · 0 comments · Fixed by #322 or #307
Assignees
@sararob
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@mikonapoli
Copy link

The description of the expiration_time for the File model is wrong and copypasted from the display_name one.

cfr

python-genai/google/genai/types.py

Line 1596 in 01b15e3

description="""Optional. The human-readable display name for the `File`. The display name must be no more than 512 characters in length, including spaces. Example: 'Welcome Image'""",

Environment details

  • Programming language: Any
  • OS: Any
  • Language runtime version: Any
  • Package version: 1.0.0

Steps to reproduce

  1. Read the description of expiration_time in google.genai.types.File.
  2. Notice that is the same as the one for display_name

Steps to fix

Change the description on the line in the url above
@mikonapoli mikonapoli added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 12, 2025
@sararob sararob self-assigned this Feb 12, 2025
copybara-service bot pushed a commit that referenced this issue Feb 12, 2025
@sararob @copybara-github
docs: fix File.expiration_time description (fixes #318)
68816b9 
PiperOrigin-RevId: 726038684
@copybara-service copybara-service bot mentioned this issue Feb 12, 2025
Merged
copybara-service bot pushed a commit that referenced this issue Feb 12, 2025
@sararob @copybara-github
docs: fix File.expiration_time description (fixes #318)
3c05350 
PiperOrigin-RevId: 726038684
copybara-service bot pushed a commit that referenced this issue Feb 12, 2025
@sararob @copybara-github
docs: fix File.expiration_time description (fixes #318)
77a99ea 
PiperOrigin-RevId: 726038684
copybara-service bot pushed a commit that referenced this issue Feb 12, 2025
@sararob @copybara-github
docs: fix File.expiration_time description (fixes #318)
e7e3985 
PiperOrigin-RevId: 726038684
@release-please release-please bot mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sararob sararob

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@sararob @mikonapoli