Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add roundingmode as str test #2098

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

chalmerlowe
Copy link
Collaborator

Adds a roundingmode test of a conditional branch that was inadvertantly stripped out by a recent change in PR: #2097

@chalmerlowe chalmerlowe requested review from a team as code owners January 2, 2025 16:54
@chalmerlowe chalmerlowe requested a review from Neenu1995 January 2, 2025 16:54
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 2, 2025
@chalmerlowe chalmerlowe changed the base branch from main to pangea-v1alpha January 2, 2025 16:55
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: xl Pull request size is extra large. labels Jan 2, 2025
@chalmerlowe chalmerlowe removed the request for review from Neenu1995 January 2, 2025 17:14
@chalmerlowe chalmerlowe changed the title Fix add roundingmode as str test Fix: add roundingmode as str test Jan 2, 2025
@chalmerlowe chalmerlowe assigned tswast and unassigned Linchin Jan 2, 2025
@chalmerlowe chalmerlowe merged commit 100708d into pangea-v1alpha Jan 2, 2025
19 checks passed
@chalmerlowe chalmerlowe deleted the fix-add-roundingmode-as-str-test branch January 2, 2025 17:23
chalmerlowe added a commit that referenced this pull request Jan 2, 2025
* fix: adds test of roundingmode as a str

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants