Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Honoring the model's supported_deployment_resources_types #865

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Nov 25, 2021

Honoring the model's supported_deployment_resources_types

See https://cloud.google.com/vertex-ai/docs/reference/rpc/google.cloud.aiplatform.v1#google.cloud.aiplatform.v1.Model.FIELDS.repeated.google.cloud.aiplatform.v1.Model.DeploymentResourcesType.google.cloud.aiplatform.v1.Model.supported_deployment_resources_types

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #773 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 25, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 25, 2021
@Ark-kun Ark-kun force-pushed the fix--Honoring-the-model's-supported_deployment_resources_types branch from 8fef755 to 3b63e9a Compare November 25, 2021 11:37
@andrewferlitsch
Copy link
Contributor

Pinged Vinny on status of review

@vinnysenthil vinnysenthil self-assigned this Jan 24, 2022
Copy link
Contributor

@vinnysenthil vinnysenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Ark-kun! Will update subsequent PRs to ensure all upstream calls of Endpoint._deploy_call pass a Model instead of model resource name, in particular #1033

@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit db34b85 into googleapis:main Mar 7, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
5 participants