Makes all code PEP8 compliant.

[dhermes]

Fixes #137.

Note that running

pep8 $(git ls-files '*py')

still has some failures. These are caused by

• test_appengine.py since dev_appserver.fix_sys_path() happens before some imports
• test_django_orm.py since modifications to django.conf.global_setting happen before some imports

and the rest are

docs/conf.py:43:1: E402 module level import not at top of file
samples/googleappengine/call_compute_service_from_gae.py:26:47: E231 missing whitespace after ','
scripts/run_system_tests.py:25:5: E129 visually indented line with same indent as next logical line
setup.py:31:1: E402 module level import not at top of file
setup.py:47:1: E402 module level import not at top of file

[nathanielmanistaatgoogle]

Thanks for the multiple well-formed commits. What do you make of Travis being displeased with this pull request?

[dhermes]

tox -e docs failed, I never ran these tests with a fresh environment (e.g. tox -e docs --recreate) and more importantly never ran it at all since tox with no environment flag just runs py26,py27,py33,py34,pypy,gae,cover.

The error was:

Warning, treated as error:
/home/travis/build/google/oauth2client/oauth2client/client.py:docstring of oauth2client.client.OAuth2Credentials.set_store:5: ERROR: Unexpected indentation.

I just git push --forced with the needed change folded into Docstring pass after pep8ify in oauth2client/. I also removed (from history) an accidental *.bak file that was added in one commit and removed in another. (Easy-ish to do while git cherry-picking the commits back together.)

---

As for the coverage drop, I kind of just brush that off. It's probably because some long lines made the total line count go up, e.g.

  # 2 spaces
  foo = datetime.datetime.utcnow() + datetime.timedelta(seconds=3600)

becoming

    # 4 spaces
    foo = (datetime.datetime.utcnow() + 
           datetime.timedelta(seconds=3600))

[dhermes]

@nathanielmanistaatgoogle Travis passes now and there is still that tiny -0.03% drop in coverage because math (#212 would make this annoyance stop).

[nathanielmanistaatgoogle]

Yeah, I agree about brushing off the coverage drop. Re-reviewing now...

[nathanielmanistaatgoogle]

LGTM; anything else to be done here?

[dhermes]

Nope. But I'd be wary of making a new release until we have 100% test coverage.