Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Adding favicon to match logo. #235

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Adding favicon to match logo. #235

merged 1 commit into from
Aug 6, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 6, 2015

Also removing empty line at the end of build-docs.

nathanielmanistaatgoogle
nathanielmanistaatgoogle reviewed Aug 6, 2015
View reviewed changes
scripts/build-docs
@@ -28,4 +28,3 @@ sphinx-apidoc -f -o docs/source oauth2client
cd docs
make html
cd ..

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@nathanielmanistaatgoogle
Copy link
Contributor

How sure are we that that's the file we wish to use? Are we following another project's example?

@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

I was just basing it off of the contents of docs/_static/google_logo.png

@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

I removed the superfluous change and sent it as #236

nathanielmanistaatgoogle added a commit that referenced this pull request Aug 6, 2015
@nathanielmanistaatgoogle
Merge pull request #235 from dhermes/add-favicon
8bb8757 
Adding favicon to match logo.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 8bb8757 into googleapis:master Aug 6, 2015
@dhermes dhermes deleted the add-favicon branch August 6, 2015 00:46
@dhermes dhermes mentioned this pull request Aug 26, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhermes @nathanielmanistaatgoogle @googlebot