Skip to content
This repository has been archived by the owner on Jan 18, 2025. It is now read-only.

Store the original id_token JWT in OAuth2Credentials #678

Closed
clancychilds opened this issue Nov 21, 2016 · 3 comments · Fixed by #680
Closed

Store the original id_token JWT in OAuth2Credentials #678

clancychilds opened this issue Nov 21, 2016 · 3 comments · Fixed by #680

Comments

@clancychilds
Copy link
Contributor

Currently, the credentials that are returned as a JWT in an identity token are extracted and stored in their extracted state, but the JWT itself is not retained. In some flows (like using the Auth0 Delegation endpoint) having the original JWT is required.
I would like to add the full JWT to the id_token dict in OAuth2Credentials. Probably as 'jwt'.

@theacodes
Copy link
Contributor

I'm open to this in general, but we're avoiding making large changes to this library unless totally necessary. Are you willing to send a PR to see what the impact will be?

@clancychilds
Copy link
Contributor Author

Yes. Working on one now.

On 21 Nov 2016 10:06 p.m., "Jon Wayne Parrott" notifications@github.com
wrote:

I'm open to this in general, but we're avoiding making large changes to
this library unless totally necessary. Are you willing to send a PR to see
what the impact will be?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#678 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AH3Nj_9c89jddnvO7nEI16QK7Bq31C9xks5rAhXagaJpZM4K4XhI
.

@clancychilds
Copy link
Contributor Author

As discussed, I have submitted a PR that would address this.
#680

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants