This repository was archived by the owner on Sep 27, 2023. It is now read-only.
feat!: adopt the new multi-pattern resource names #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
============================================
- Coverage 71.87% 70.69% -1.19%
Complexity 331 331
============================================
Files 42 42
Lines 2642 2692 +50
Branches 15 15
============================================
+ Hits 1899 1903 +4
- Misses 706 750 +44
- Partials 37 39 +2
Continue to review full report at Codecov.
|
|
PTAL @chingor13 |
chingor13
suggested changes
Mar 12, 2020
| @@ -16,4 +16,13 @@ | |||
| <className>com/google/cloud/talent/v4beta1/*OrBuilder</className> | |||
| <method>boolean has*(*)</method> | |||
| </difference> | |||
| <difference> | |||
| <differenceType>8001</differenceType> | |||
| <className>com/google/cloud/talent/v4beta1/*Name*</className> | |||
There was a problem hiding this comment.
Let's be more explicit on exactly which classes are ok to remove in this PR.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- see http://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html --> | ||
| <differences> | ||
| <!--TODO: To be removed--> |
chingor13
approved these changes
Mar 13, 2020
Closed
vam-google
pushed a commit
to vam-google/java-talent
that referenced
this pull request
Mar 20, 2020
…gleapis#88) * chore: update repo-metadata and regenerate README from templates * restore examples * fix pretty name
Closed
Merged
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 27, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [0.36.0](https://github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27) ### ⚠ BREAKING CHANGES * use `TenantName` for resources in place of `TenantOrProjectName` * adopt the new multi-pattern resource names (#88) ### Features * adopt the new multi-pattern resource names ([#88](https://github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3)) * resource name change ([#106](https://github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c)) ### Bug Fixes * undeprecate resource name classes until multi-pattern resources are available ([#83](https://github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b)) ### Dependencies * update core dependencies ([#84](https://github.com/googleapis/java-talent/issues/84)) ([2824acd](https://github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c)) * update dependency com.google.api:api-common to v1.9.0 ([#108](https://github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465)) * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604)) * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c)) ### Documentation * **regen:** update generate proto documentation ([#86](https://github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01)) * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Mar 27, 2020
4a4a1df commit 4a4a1df Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Fri Mar 27 21:44:09 2020 +0000 chore: release 0.36.0 (#113) 🤖 I have created a release \*beep\* \*boop\* --- ## [0.36.0](https://github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27) ### ⚠ BREAKING CHANGES * use `TenantName` for resources in place of `TenantOrProjectName` * adopt the new multi-pattern resource names (#88) ### Features * adopt the new multi-pattern resource names ([#88](https://github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3)) * resource name change ([#106](https://github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c)) ### Bug Fixes * undeprecate resource name classes until multi-pattern resources are available ([#83](https://github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b)) ### Dependencies * update core dependencies ([#84](https://github.com/googleapis/java-talent/issues/84)) ([2824acd](https://github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c)) * update dependency com.google.api:api-common to v1.9.0 ([#108](https://github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465)) * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604)) * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c)) ### Documentation * **regen:** update generate proto documentation ([#86](https://github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01)) * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Mar 28, 2020
4a4a1df commit 4a4a1df Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Fri Mar 27 21:44:09 2020 +0000 chore: release 0.36.0 (#113) 🤖 I have created a release \*beep\* \*boop\* --- ## [0.36.0](https://github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27) ### ⚠ BREAKING CHANGES * use `TenantName` for resources in place of `TenantOrProjectName` * adopt the new multi-pattern resource names (#88) ### Features * adopt the new multi-pattern resource names ([#88](https://github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3)) * resource name change ([#106](https://github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c)) ### Bug Fixes * undeprecate resource name classes until multi-pattern resources are available ([#83](https://github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b)) ### Dependencies * update core dependencies ([#84](https://github.com/googleapis/java-talent/issues/84)) ([2824acd](https://github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c)) * update dependency com.google.api:api-common to v1.9.0 ([#108](https://github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465)) * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604)) * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c)) ### Documentation * **regen:** update generate proto documentation ([#86](https://github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01)) * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
yoshi-automation
added a commit
that referenced
this pull request
Apr 2, 2020
4a4a1df commit 4a4a1df Author: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Date: Fri Mar 27 21:44:09 2020 +0000 chore: release 0.36.0 (#113) 🤖 I have created a release \*beep\* \*boop\* --- ## [0.36.0](https://github.com/googleapis/java-talent/compare/v0.35.2...v0.36.0) (2020-03-27) ### ⚠ BREAKING CHANGES * use `TenantName` for resources in place of `TenantOrProjectName` * adopt the new multi-pattern resource names (#88) ### Features * adopt the new multi-pattern resource names ([#88](https://github.com/googleapis/java-talent/issues/88)) ([0a8a4c9](https://github.com/googleapis/java-talent/commit/0a8a4c9141e5b024ab4106975690f6b3f1c91bf3)) * resource name change ([#106](https://github.com/googleapis/java-talent/issues/106)) ([2c44fa8](https://github.com/googleapis/java-talent/commit/2c44fa85b84cb8b64715a784b9c960a0ac23065c)) ### Bug Fixes * undeprecate resource name classes until multi-pattern resources are available ([#83](https://github.com/googleapis/java-talent/issues/83)) ([c6ac9f8](https://github.com/googleapis/java-talent/commit/c6ac9f825e122cd4805f51ae5ef3fc9e2185ca1b)) ### Dependencies * update core dependencies ([#84](https://github.com/googleapis/java-talent/issues/84)) ([2824acd](https://github.com/googleapis/java-talent/commit/2824acd3d725f7a2b2c246dad5140e248ceb318c)) * update dependency com.google.api:api-common to v1.9.0 ([#108](https://github.com/googleapis/java-talent/issues/108)) ([3e9cd1f](https://github.com/googleapis/java-talent/commit/3e9cd1fbd46f00d83dd5cedcce487644ba7eb465)) * update dependency com.google.cloud:google-cloud-core to v1.92.5 ([bd15e46](https://github.com/googleapis/java-talent/commit/bd15e4646a653e0951999a35336c472bc3c1661c)) * update dependency com.google.protobuf:protobuf-java to v3.11.4 ([e6ca466](https://github.com/googleapis/java-talent/commit/e6ca46662f9f78760fde934e23deaa1d4582d604)) * update dependency io.grpc:grpc-bom to v1.27.1 ([b9a488d](https://github.com/googleapis/java-talent/commit/b9a488d3356e772131a427934011d5f4543fac2c)) ### Documentation * **regen:** update generate proto documentation ([#86](https://github.com/googleapis/java-talent/issues/86)) ([3e2a860](https://github.com/googleapis/java-talent/commit/3e2a860d3d10cb46dcbe97582afc0b283d591f01)) * **regen:** update sample code to set total timeout, add API client header test ([10922f4](https://github.com/googleapis/java-talent/commit/10922f4c050ea3a54e57c30d5963d95e749228dd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TenantOrProjectName.TenantNameandProjectNamerespectively whereTenantOrProjectNamewas originally used.CompanyWithTenantName,CompanyWithoutTenantName,JobWithTenantName,JobWithoutTenantName,CompanyOldName,CompanyNewName,JobOldName,JobNewName.JobNames,CompanyNames,TenantOrProjectNamesand untyped resource name classesUntypedJobName,UntypedTenantNameandUntypedTenantOrProjectName.