Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: keep comments when searching for params #2951

Merged
merged 7 commits into from
Mar 19, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into convert-params-with-comments
olavloite committed Mar 19, 2024
commit 2a10a12cb33599e1db1dee67c3d0cc280ea5dae6
Original file line number Diff line number Diff line change
@@ -697,7 +697,11 @@ public boolean checkReturningClause(String sql) {
}

/**
<<<<<<< HEAD
* Returns true if this dialect supports nested comments.
=======
* <<<<<<< HEAD Returns true if this dialect supports nested comments.
>>>>>>> main
*
* <ul>
* <li>This method should return false for dialects that consider this to be a valid comment:
Original file line number Diff line number Diff line change
@@ -21,6 +21,9 @@

import com.google.cloud.spanner.Dialect;
import com.google.cloud.spanner.connection.StatementParserTest.CommentInjector;
import static org.junit.Assert.assertEquals;

import com.google.cloud.spanner.Dialect;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
You are viewing a condensed version of this merge commit. You can view the full changes here.