feat: dashboard updates

.kokoro/deps-finder.sh

@@ -33,7 +33,8 @@ source ${scriptDir}/shared-deps-helper.sh
 # Dependency should be of the form artifactId:version
 
 function checkLibrary() {
-  clientLibrary=$1 # Should be of the format artifactId:version
+  # Should be of the format artifactId:version
+  clientLibrary=$1
 
   # If no dependency was passed straight to the script, check our most recent commit for a dep version update.
   if [[ -z ${clientLibrary} ]]; then
@@ -62,8 +63,10 @@ function checkLibrary() {
     fi
   fi
 
-  depVersion=${clientLibrary/*:/} # Grab last part of dependency artifactId:version input.
-  depVersion=${depVersion/-*/}    # Remove any alphabetical characters at the end (e.g. -alpha, -beta, etc)
+  # Grab last part of dependency artifactId:version input.
+  # Remove any alphabetical characters at the end (e.g. -alpha, -beta, etc)
+  depVersion=${clientLibrary/*:/}
+  depVersion=${depVersion/-*/}
 
   pomLocation="/pom.xml"
 

.kokoro/release-versions.sh

@@ -62,7 +62,7 @@ function releaseVersionsCheck() {
       break
     fi
     depsManaged=${depsManaged/*$currentLibrary/} #Remove this client library from our list of dependencies
-    # Check if we're looking at a valid dependency (starts with google-cloud and is nonempty)
+    # Check if we're looking at a valid dependency (contains with google-cloud)
     if [[ ! -z $(echo ${currentLibrary} | grep "google-cloud") ]]; then
       artifactId=${currentLibrary/*<artifactId>/}
       artifactId=${artifactId/<\/artifactId>*/}
@@ -102,7 +102,8 @@ set +e
 
 # Allow the script to run normally if we're passed any argument
 if [[ -z $1 ]]; then
-  isReleaseBranch # Otherwise if we're on a release branch
+  # Otherwise if we're on a release branch
+  isReleaseBranch
   if [[ ! $? -eq 0 ]]; then
     msg "This is either a SNAPSHOT release or not a release! Returning success!"
     exit 0
@@ -111,10 +112,11 @@ fi
 
 releaseVersionsCheck
 
+# We fail if the number of failing client libraries is > 0.
 if [[ $? -eq 0 ]]; then
   msg "Check passed. All libraries have the correct version of java-shared-dependencies!"
   exit 0
-else # We fail if the number of failing client libraries is > 0.
+else
   if [[ ! -z ${successfulClientLibraries} ]]; then
     echo "------------------------------------------------------------------------------"
     msg "Successful Client Libraries: "

.kokoro/shared-deps-helper.sh

@@ -1,9 +1,22 @@
 #!/bin/bash
-
-#Helper functions for the deps-finder and release-versions scripts.
-
+# Copyright 2020 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# Helper functions for the deps-finder and release-versions scripts.
 function isReleaseBranch() {
-  #Check if we're currently on a non-SNAPSHOT release branch. If we are, we want to run the check.
+  # Check if we're currently on a non-SNAPSHOT release branch.
+  # If we are, we want to run the check.
   currBranch=$(git rev-parse --abbrev-ref HEAD | grep "release-v")
   snapShotCheck=$(echo ${currBranch} | grep "\-SNAPSHOT")
   if [[ -z ${currBranch} ]] || [[ ! -z ${snapShotCheck} ]]; then
@@ -12,8 +25,8 @@ function isReleaseBranch() {
   return 0
 }
 
-#  Returns 1 if we find an updated client library in the commit message.
-#Echos client library (if found) before completion.
+# Returns 1 if we find an updated client library in the commit message.
+# Echos client library (if found) before completion.
 function getLibraryUpdate() {
   currentCommitNumber=$(git rev-parse HEAD)
 
@@ -27,7 +40,7 @@ function getLibraryUpdate() {
 
   #  Use regex to grab the dependency group and artifact IDs
 
-  #Find group and artifact by format
+  # Find group and artifact by format
   groupAndArtifact=$(echo ${currentCommitMessage} | grep -oP 'com.google.cloud:google-cloud-\S+')
 
   # Grab Artifact
@@ -44,7 +57,7 @@ function getLibraryUpdate() {
     return 1
   fi
 
-  echo "$artifactAndVersion"
+  echo "${artifactAndVersion}"
   return 0
 }