Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: clean up mirroring client deps #4261

Merged
merged 1 commit into from
Nov 29, 2023
Merged

deps: clean up mirroring client deps #4261

merged 1 commit into from
Nov 29, 2023

Conversation

igorbernstein2
Copy link
Collaborator

  • add IDE workaround for mirroring-client shaded deps to be resolved from ~/.m2
  • drop shading from intermediate artifacts
  • organize mirroring client poms so that env deps come first
  • update mirroring client integration tests to avoid duplicated classes from hbase-shaded-client and hbase-shaded-testing-util
  • use reload4j for integration test logging
  • add google-cloud-bigtable as a dep to integration test modules to resolve conflict about guava
  • update integration test modules to exclude transitive deps from each other to make easier to reason about the classpath

Change-Id: I0a9c57ac5eac609847cb28014c156436fb94abe2

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@igorbernstein2
deps: clean up mirroring client deps
724cbf2 
* add IDE workaround for mirroring-client shaded deps to be resolved from ~/.m2
* drop shading from intermediate artifacts
* organize mirroring client poms so that env deps come first
* update mirroring client integration tests to avoid duplicated classes from hbase-shaded-client and hbase-shaded-testing-util
* use reload4j for integration test logging
* add google-cloud-bigtable as a dep to integration test modules to resolve conflict about guava
* update integration test modules to exclude transitive deps from each other to make easier to reason about the classpath

Change-Id: I0a9c57ac5eac609847cb28014c156436fb94abe2
@igorbernstein2 igorbernstein2 requested a review from a team as a code owner November 28, 2023 21:13
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigtable Issues related to the googleapis/java-bigtable-hbase API. labels Nov 28, 2023
@igorbernstein2 igorbernstein2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@igorbernstein2 igorbernstein2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 28, 2023
@igorbernstein2 igorbernstein2 merged commit ce9e53b into googleapis:main Nov 29, 2023
@release-please release-please bot mentioned this pull request Nov 29, 2023
Merged
@chingor13 chingor13 mentioned this pull request Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igorbernstein2 @mutianf @yoshi-kokoro