Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x #2773

Merged
merged 4 commits into from
Dec 29, 2020
Merged

fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x #2773

merged 4 commits into from
Dec 29, 2020

Conversation

dmitry-fa
Copy link
Contributor

Fixes #2601

@dmitry-fa dmitry-fa requested a review from a team as a code owner December 21, 2020 10:55
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 21, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable-hbase API. label Dec 21, 2020
@dmitry-fa dmitry-fa requested a review from kolea2 December 24, 2020 11:30
kolea2
kolea2 reviewed Dec 28, 2020
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small comment

kolea2
kolea2 suggested changes Dec 29, 2020
View reviewed changes
Copy link
Contributor

@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after last comment change

@dmitry-fa dmitry-fa requested a review from kolea2 December 29, 2020 17:17
@kolea2 kolea2 added automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. labels Dec 29, 2020
@kolea2 kolea2 merged commit 1792c60 into googleapis:master Dec 29, 2020
@kolea2 kolea2 mentioned this pull request Dec 30, 2020
Closed
3 tasks
@kolea2
Copy link
Contributor

kolea2 commented Dec 30, 2020

Opened #2785 to track this for 1.x branch as well

vermas2012 pushed a commit to vermas2012/java-bigtable-hbase that referenced this pull request Jan 1, 2021
@dmitry-fa @vermas2012
fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client …
e8b5d36 
…2.x (googleapis#2773)

* fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x

* test: unit tests for BigtableAdmin.getClusterStatus()

* fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x

* fix: copyright header
@syucream
Copy link

Any plan to release it?

kolea2 pushed a commit to kolea2/cloud-bigtable-client that referenced this pull request Mar 3, 2021
@dmitry-fa @kolea2
fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client …
752131b 
…2.x (googleapis#2773)

(cherry picked from commit 1792c60)
@kolea2 kolea2 mentioned this pull request Mar 3, 2021
Closed
kolea2 pushed a commit to kolea2/cloud-bigtable-client that referenced this pull request Mar 3, 2021
@dmitry-fa @kolea2
fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client …
bfd728e 
…2.x (googleapis#2773)

(cherry picked from commit 1792c60)
@kolea2 kolea2 mentioned this pull request Mar 3, 2021
Merged
kolea2 added a commit that referenced this pull request Mar 5, 2021
@kolea2 @dmitry-fa
fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client …
b74ba4f 
…2.x (#2773) (#2864)

* fix: bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x (#2773)

(cherry picked from commit 1792c60)

* align to 1x api

Co-authored-by: Dmitry <58846611+dmitry-fa@users.noreply.github.com>
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 19, 2021
@release-please
chore(bigtable-1.x): release 1.19.1 (#2887)
05ee945 
🤖 I have created a release \*beep\* \*boop\*
---
### [1.19.1](https://github.com/googleapis/java-bigtable-hbase/compare/v1.19.0...v1.19.1) (2021-03-18)


### Bug Fixes

* bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x ([#2773](https://github.com/googleapis/java-bigtable-hbase/issues/2773)) ([#2864](https://github.com/googleapis/java-bigtable-hbase/issues/2864)) ([b74ba4f](https://github.com/googleapis/java-bigtable-hbase/commit/b74ba4f5f4de0001391b85ffc9669ca46c187faa))
* Disabling Dataflow memory monitor for Bigtable Dataflow pipelines. ([#2856](https://github.com/googleapis/java-bigtable-hbase/issues/2856)) ([2af6202](https://github.com/googleapis/java-bigtable-hbase/commit/2af620239fa18a06eccb1547e92e82f15be71e47))
* hbase 2x shell ([#2905](https://github.com/googleapis/java-bigtable-hbase/issues/2905)) ([e74015b](https://github.com/googleapis/java-bigtable-hbase/commit/e74015b473d031edd77d896b05c55aa48c3848d4))
* updated assertions and scan for firstKeyOnlyFilter test ([#2483](https://github.com/googleapis/java-bigtable-hbase/issues/2483)) ([#2854](https://github.com/googleapis/java-bigtable-hbase/issues/2854)) ([c150262](https://github.com/googleapis/java-bigtable-hbase/commit/c150262267734164080c6ab5e3f991a140067408))


### Dependencies

* Update beam version to 2.24.0 ([#2857](https://github.com/googleapis/java-bigtable-hbase/issues/2857)) ([94aea7c](https://github.com/googleapis/java-bigtable-hbase/commit/94aea7c1e4260b067ab429f40ee018abfd3e22f7))
* update shared config to 0.10.0 ([#2826](https://github.com/googleapis/java-bigtable-hbase/issues/2826)) ([a20c746](https://github.com/googleapis/java-bigtable-hbase/commit/a20c7466412f1b97a4c00fc8611fe05b057d7b6d))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kolea2 kolea2 kolea2 approved these changes

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable-hbase API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x
3 participants
@dmitry-fa @kolea2 @syucream