Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation of TimeRange #1890

Merged
merged 3 commits into from
Jul 19, 2018
Merged

fix: validation of TimeRange #1890

merged 3 commits into from
Jul 19, 2018

Conversation

piroyoung
Copy link

Every valid TimeRange will be denied.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2018
@sduskis sduskis self-requested a review July 19, 2018 12:07
@sduskis sduskis changed the title fix: varidation of TimeRange fix: validation of TimeRange Jul 19, 2018
@sduskis
Copy link
Contributor

sduskis commented Jul 19, 2018

This change reflects the fact that we don't have enough Unit and Integration tests for this. I'll add those in a separate PR.

@sduskis sduskis closed this Jul 19, 2018
@sduskis sduskis reopened this Jul 19, 2018
@sduskis sduskis merged commit 7f404e4 into googleapis:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis Awaiting requested review from sduskis

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piroyoung @sduskis @googlebot