fix: updated assertions and scan for firstKeyOnlyFilter test #2483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates integration tests assertions to verify firstKeyOnlyFilter.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #2483 +/- ##
============================================
+ Coverage 61.74% 62.37% +0.62%
- Complexity 1608 1636 +28
============================================
Files 197 200 +3
Lines 9992 10139 +147
Branches 1022 1031 +9
============================================
+ Hits 6170 6324 +154
+ Misses 3360 3352 -8
- Partials 462 463 +1
Continue to review full report at Codecov.
|
…alue This commit partially reverts changes from googleapis#1996 to have consistent behavior with HBase FirstKeyOnlyFilter.
rahulKQL
changed the title
rahulKQL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
3 tasks
kolea2
pushed a commit
to kolea2/cloud-bigtable-client
that referenced
this pull request
Mar 1, 2021
…pis#2483) * chore(test): updated assertions for firstKeyOnlyFilter This PR updates integration tests assertions to verify firstKeyOnlyFilter. * chore: reverting back FirstKeyOnlyFilterAdapter to return cell with value This commit partially reverts changes from googleapis#1996 to have consistent behavior with HBase FirstKeyOnlyFilter. * to trigger failed CI Job (cherry picked from commit a2cbe7a)
kolea2
added a commit
that referenced
this pull request
Mar 3, 2021
…2854) * chore(test): updated assertions for firstKeyOnlyFilter This PR updates integration tests assertions to verify firstKeyOnlyFilter. * chore: reverting back FirstKeyOnlyFilterAdapter to return cell with value This commit partially reverts changes from #1996 to have consistent behavior with HBase FirstKeyOnlyFilter. * to trigger failed CI Job (cherry picked from commit a2cbe7a) Co-authored-by: Rahul Kesharwani <42969463+rahulKQL@users.noreply.github.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 19, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [1.19.1](https://github.com/googleapis/java-bigtable-hbase/compare/v1.19.0...v1.19.1) (2021-03-18) ### Bug Fixes * bigtable-hbase-2.x-hadoop incompatible with hbase-shaded-client 2.x ([#2773](https://github.com/googleapis/java-bigtable-hbase/issues/2773)) ([#2864](https://github.com/googleapis/java-bigtable-hbase/issues/2864)) ([b74ba4f](https://github.com/googleapis/java-bigtable-hbase/commit/b74ba4f5f4de0001391b85ffc9669ca46c187faa)) * Disabling Dataflow memory monitor for Bigtable Dataflow pipelines. ([#2856](https://github.com/googleapis/java-bigtable-hbase/issues/2856)) ([2af6202](https://github.com/googleapis/java-bigtable-hbase/commit/2af620239fa18a06eccb1547e92e82f15be71e47)) * hbase 2x shell ([#2905](https://github.com/googleapis/java-bigtable-hbase/issues/2905)) ([e74015b](https://github.com/googleapis/java-bigtable-hbase/commit/e74015b473d031edd77d896b05c55aa48c3848d4)) * updated assertions and scan for firstKeyOnlyFilter test ([#2483](https://github.com/googleapis/java-bigtable-hbase/issues/2483)) ([#2854](https://github.com/googleapis/java-bigtable-hbase/issues/2854)) ([c150262](https://github.com/googleapis/java-bigtable-hbase/commit/c150262267734164080c6ab5e3f991a140067408)) ### Dependencies * Update beam version to 2.24.0 ([#2857](https://github.com/googleapis/java-bigtable-hbase/issues/2857)) ([94aea7c](https://github.com/googleapis/java-bigtable-hbase/commit/94aea7c1e4260b067ab429f40ee018abfd3e22f7)) * update shared config to 0.10.0 ([#2826](https://github.com/googleapis/java-bigtable-hbase/issues/2826)) ([a20c746](https://github.com/googleapis/java-bigtable-hbase/commit/a20c7466412f1b97a4c00fc8611fe05b057d7b6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2477
This PR update integration test to perform a
scanandrowKeyassertions to verify firstKeyOnlyFilter functionality.