Adding a gzip-ed text file for requests download system test.
#35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace `IMG_FILES` (tuple of `str`) with `ALL_FILES`, which is a tuple of info dictionaries for each file (including `path` and `content_type`) - Factor the slice choices out of `test_download_partial` and `test_chunked_download_partial` and put them in `ALL_FILES`
This has revealed at least two errors and this is intended to be checked in in a broken state, so that subsequent PRs can fix it.
dhermes
commented
Oct 20, 2017
| u'content_type': PLAIN_TEXT, | ||
| # NOTE: This **should** be u'KHRs/+ZSrc/FuuR4qz/PZQ=='. | ||
| u'checksum': u'XHSHAr/SpIeZtZbjgQ4nGw==', | ||
| u'slices': (), |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
tseaver
approved these changes
Oct 20, 2017
|
Thanks @tseaver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has revealed at least two errors and this is intended to be checked in in a broken state, so that subsequent PRs can fix it. (See dhermes@29617b6 for a preview of one such fix).
In order to make this easy, I re-factored the tests in a commit before, so it's likely easier to review this PR commit-by-commit.
/cc @tseaver @mfschwartz