Requester pays: expose userProject #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…java into requester_pays
googlebot
added
the
cla: yes
|
Not ready for review; just running CI |
andreamlin
requested review from
vam-google
and removed request for
garrettjonesgoogle
|
PTAL |
vam-google
reviewed
Oct 26, 2017
There was a problem hiding this comment.
@garrettjonesgoogle Storage is a GA library and with this PR we update the underlying http and apiary clients used. I hope it is still ok, but please confirm.
| @@ -252,6 +252,7 @@ public StorageObject create(StorageObject storageObject, final InputStream conte | |||
| .setMaxResults(Option.MAX_RESULTS.getLong(options)) | |||
| .setPageToken(Option.PAGE_TOKEN.getString(options)) | |||
| .setFields(Option.FIELDS.getString(options)) | |||
| .setUserProject(Option.FIELDS.getString(options)) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@vam-google updating the underlying http and apiary clients should be fine - they don't form part of the surface of google-cloud-storage. |
|
Fixed bugs. PTAL |
This was referenced Oct 26, 2017
schmidt-sebastian
pushed a commit
to FirebasePrivate/google-cloud-java
that referenced
this pull request
Nov 9, 2017
Expose the userProject parameter for the List.Buckets operation. Bump google-api-client dependency to 1.23.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the userProject parameter for the List.Buckets operation.
Bump google-api-client dependency to 1.23.0.