Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix on duplicate label #1995

Merged
merged 1 commit into from
Apr 25, 2017
Merged

bug fix on duplicate label #1995

merged 1 commit into from
Apr 25, 2017

Conversation

jabubake
Copy link
Contributor

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2017
@garrettjonesgoogle
Copy link
Member

LGTM after tests pass

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4d5d80b on jabubake:logging_fix into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle
Copy link
Member

(Wait to merge until the rc4 release is done)

@garrettjonesgoogle garrettjonesgoogle merged commit dd09d48 into googleapis:master Apr 25, 2017
@jabubake jabubake deleted the logging_fix branch April 25, 2017 21:47
@meltsufin
Copy link
Member

Looks like we need this fix as well. When can we expect rc5?

@gregw FYI

@jabubake
Copy link
Contributor Author

jabubake commented Apr 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jabubake @garrettjonesgoogle @coveralls @meltsufin @googlebot