Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aiplatform/v1beta1): [aiplatform] change CreateFeature metadata #10029

Merged
merged 4 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ public final UnaryCallable<DeleteFeatureGroupRequest, Operation> deleteFeatureGr
* <p>The value must be unique within an EntityType/FeatureGroup.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> createFeatureAsync(
public final OperationFuture<Feature, CreateFeatureOperationMetadata> createFeatureAsync(
EntityTypeName parent, Feature feature, String featureId) {
CreateFeatureRequest request =
CreateFeatureRequest.newBuilder()
Expand Down Expand Up @@ -1042,7 +1042,7 @@ public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> cr
* <p>The value must be unique within an EntityType/FeatureGroup.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> createFeatureAsync(
public final OperationFuture<Feature, CreateFeatureOperationMetadata> createFeatureAsync(
FeatureGroupName parent, Feature feature, String featureId) {
CreateFeatureRequest request =
CreateFeatureRequest.newBuilder()
Expand Down Expand Up @@ -1086,7 +1086,7 @@ public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> cr
* <p>The value must be unique within an EntityType/FeatureGroup.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> createFeatureAsync(
public final OperationFuture<Feature, CreateFeatureOperationMetadata> createFeatureAsync(
String parent, Feature feature, String featureId) {
CreateFeatureRequest request =
CreateFeatureRequest.newBuilder()
Expand Down Expand Up @@ -1126,7 +1126,7 @@ public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> cr
* @param request The request object containing all of the parameters for the API call.
* @throws com.google.api.gax.rpc.ApiException if the remote call fails
*/
public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> createFeatureAsync(
public final OperationFuture<Feature, CreateFeatureOperationMetadata> createFeatureAsync(
CreateFeatureRequest request) {
return createFeatureOperationCallable().futureCall(request);
}
Expand All @@ -1153,15 +1153,14 @@ public final OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> cr
* .setFeature(Feature.newBuilder().build())
* .setFeatureId("featureId-420503887")
* .build();
* OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> future =
* OperationFuture<Feature, CreateFeatureOperationMetadata> future =
* featureRegistryServiceClient.createFeatureOperationCallable().futureCall(request);
* // Do something.
* Feature response = future.get();
* }
* }</pre>
*/
public final OperationCallable<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
public final OperationCallable<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationCallable() {
return stub.createFeatureOperationCallable();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,7 @@ public UnaryCallSettings<CreateFeatureRequest, Operation> createFeatureSettings(
}

/** Returns the object with the settings used for calls to createFeature. */
public OperationCallSettings<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
public OperationCallSettings<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings() {
return ((FeatureRegistryServiceStubSettings) getStubSettings())
.createFeatureOperationSettings();
Expand Down Expand Up @@ -371,7 +370,7 @@ public UnaryCallSettings.Builder<CreateFeatureRequest, Operation> createFeatureS

/** Returns the builder for the settings used for calls to createFeature. */
public OperationCallSettings.Builder<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings() {
return getStubSettingsBuilder().createFeatureOperationSettings();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.CreateRegistryFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteOperationMetadata;
Expand Down Expand Up @@ -117,7 +117,7 @@ public UnaryCallable<DeleteFeatureGroupRequest, Operation> deleteFeatureGroupCal
throw new UnsupportedOperationException("Not implemented: deleteFeatureGroupCallable()");
}

public OperationCallable<CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
public OperationCallable<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationCallable() {
throw new UnsupportedOperationException("Not implemented: createFeatureOperationCallable()");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.CreateRegistryFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteOperationMetadata;
Expand Down Expand Up @@ -147,8 +147,7 @@ public class FeatureRegistryServiceStubSettings
private final OperationCallSettings<DeleteFeatureGroupRequest, Empty, DeleteOperationMetadata>
deleteFeatureGroupOperationSettings;
private final UnaryCallSettings<CreateFeatureRequest, Operation> createFeatureSettings;
private final OperationCallSettings<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
private final OperationCallSettings<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings;
private final UnaryCallSettings<GetFeatureRequest, Feature> getFeatureSettings;
private final PagedCallSettings<
Expand Down Expand Up @@ -389,8 +388,7 @@ public UnaryCallSettings<CreateFeatureRequest, Operation> createFeatureSettings(
}

/** Returns the object with the settings used for calls to createFeature. */
public OperationCallSettings<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
public OperationCallSettings<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings() {
return createFeatureOperationSettings;
}
Expand Down Expand Up @@ -582,7 +580,7 @@ public static class Builder
deleteFeatureGroupOperationSettings;
private final UnaryCallSettings.Builder<CreateFeatureRequest, Operation> createFeatureSettings;
private final OperationCallSettings.Builder<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings;
private final UnaryCallSettings.Builder<GetFeatureRequest, Feature> getFeatureSettings;
private final PagedCallSettings.Builder<
Expand Down Expand Up @@ -895,7 +893,7 @@ private static Builder initDefaults(Builder builder) {
ProtoOperationTransformers.ResponseTransformer.create(Feature.class))
.setMetadataTransformer(
ProtoOperationTransformers.MetadataTransformer.create(
CreateRegistryFeatureOperationMetadata.class))
CreateFeatureOperationMetadata.class))
.setPollingAlgorithm(
OperationTimedPollAlgorithm.create(
RetrySettings.newBuilder()
Expand Down Expand Up @@ -1041,7 +1039,7 @@ public UnaryCallSettings.Builder<CreateFeatureRequest, Operation> createFeatureS
@BetaApi(
"The surface for use by generated code is not stable yet and may change in the future.")
public OperationCallSettings.Builder<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationSettings() {
return createFeatureOperationSettings;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.CreateRegistryFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureGroupRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.DeleteOperationMetadata;
Expand Down Expand Up @@ -246,8 +246,7 @@ public class GrpcFeatureRegistryServiceStub extends FeatureRegistryServiceStub {
private final OperationCallable<DeleteFeatureGroupRequest, Empty, DeleteOperationMetadata>
deleteFeatureGroupOperationCallable;
private final UnaryCallable<CreateFeatureRequest, Operation> createFeatureCallable;
private final OperationCallable<
CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
private final OperationCallable<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationCallable;
private final UnaryCallable<GetFeatureRequest, Feature> getFeatureCallable;
private final UnaryCallable<ListFeaturesRequest, ListFeaturesResponse> listFeaturesCallable;
Expand Down Expand Up @@ -635,7 +634,7 @@ public UnaryCallable<CreateFeatureRequest, Operation> createFeatureCallable() {
}

@Override
public OperationCallable<CreateFeatureRequest, Feature, CreateRegistryFeatureOperationMetadata>
public OperationCallable<CreateFeatureRequest, Feature, CreateFeatureOperationMetadata>
createFeatureOperationCallable() {
return createFeatureOperationCallable;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "nericOperationMetadata\"u\n\036UpdateFeatureO"
+ "perationMetadata\022S\n\020generic_metadata\030\001 \001"
+ "(\01329.google.cloud.aiplatform.v1beta1.Gen"
+ "ericOperationMetadata2\307\023\n\026FeatureRegistr"
+ "ericOperationMetadata2\277\023\n\026FeatureRegistr"
+ "yService\022\235\002\n\022CreateFeatureGroup\022:.google"
+ ".cloud.aiplatform.v1beta1.CreateFeatureG"
+ "roupRequest\032\035.google.longrunning.Operati"
Expand Down Expand Up @@ -153,45 +153,45 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ ".google.longrunning.Operation\"~\312A0\n\025goog"
+ "le.protobuf.Empty\022\027DeleteOperationMetada"
+ "ta\332A\nname,force\202\323\344\223\0028*6/v1beta1/{name=pr"
+ "ojects/*/locations/*/featureGroups/*}\022\212\002"
+ "ojects/*/locations/*/featureGroups/*}\022\202\002"
+ "\n\rCreateFeature\0225.google.cloud.aiplatfor"
+ "m.v1beta1.CreateFeatureRequest\032\035.google."
+ "longrunning.Operation\"\242\001\312A1\n\007Feature\022&Cr"
+ "eateRegistryFeatureOperationMetadata\332A\031p"
+ "arent,feature,feature_id\202\323\344\223\002L\"A/v1beta1"
+ "/{parent=projects/*/locations/*/featureG"
+ "roups/*}/features:\007feature\022\274\001\n\nGetFeatur"
+ "e\0222.google.cloud.aiplatform.v1beta1.GetF"
+ "eatureRequest\032(.google.cloud.aiplatform."
+ "v1beta1.Feature\"P\332A\004name\202\323\344\223\002C\022A/v1beta1"
+ "/{name=projects/*/locations/*/featureGro"
+ "ups/*/features/*}\022\317\001\n\014ListFeatures\0224.goo"
+ "gle.cloud.aiplatform.v1beta1.ListFeature"
+ "sRequest\0325.google.cloud.aiplatform.v1bet"
+ "a1.ListFeaturesResponse\"R\332A\006parent\202\323\344\223\002C"
+ "\022A/v1beta1/{parent=projects/*/locations/"
+ "*/featureGroups/*}/features\022\204\002\n\rUpdateFe"
+ "ature\0225.google.cloud.aiplatform.v1beta1."
+ "UpdateFeatureRequest\032\035.google.longrunnin"
+ "g.Operation\"\234\001\312A)\n\007Feature\022\036UpdateFeatur"
+ "eOperationMetadata\332A\023feature,update_mask"
+ "\202\323\344\223\002T2I/v1beta1/{feature.name=projects/"
+ "*/locations/*/featureGroups/*/features/*"
+ "}:\007feature\022\353\001\n\rDeleteFeature\0225.google.cl"
+ "oud.aiplatform.v1beta1.DeleteFeatureRequ"
+ "est\032\035.google.longrunning.Operation\"\203\001\312A0"
+ "\n\025google.protobuf.Empty\022\027DeleteOperation"
+ "Metadata\332A\004name\202\323\344\223\002C*A/v1beta1/{name=pr"
+ "ojects/*/locations/*/featureGroups/*/fea"
+ "tures/*}\032M\312A\031aiplatform.googleapis.com\322A"
+ ".https://www.googleapis.com/auth/cloud-p"
+ "latformB\362\001\n#com.google.cloud.aiplatform."
+ "v1beta1B\033FeatureRegistryServiceProtoP\001ZC"
+ "cloud.google.com/go/aiplatform/apiv1beta"
+ "1/aiplatformpb;aiplatformpb\252\002\037Google.Clo"
+ "ud.AIPlatform.V1Beta1\312\002\037Google\\Cloud\\AIP"
+ "latform\\V1beta1\352\002\"Google::Cloud::AIPlatf"
+ "orm::V1beta1b\006proto3"
+ "longrunning.Operation\"\232\001\312A)\n\007Feature\022\036Cr"
+ "eateFeatureOperationMetadata\332A\031parent,fe"
+ "ature,feature_id\202\323\344\223\002L\"A/v1beta1/{parent"
+ "=projects/*/locations/*/featureGroups/*}"
+ "/features:\007feature\022\274\001\n\nGetFeature\0222.goog"
+ "le.cloud.aiplatform.v1beta1.GetFeatureRe"
+ "quest\032(.google.cloud.aiplatform.v1beta1."
+ "Feature\"P\332A\004name\202\323\344\223\002C\022A/v1beta1/{name=p"
+ "rojects/*/locations/*/featureGroups/*/fe"
+ "atures/*}\022\317\001\n\014ListFeatures\0224.google.clou"
+ "d.aiplatform.v1beta1.ListFeaturesRequest"
+ "\0325.google.cloud.aiplatform.v1beta1.ListF"
+ "eaturesResponse\"R\332A\006parent\202\323\344\223\002C\022A/v1bet"
+ "a1/{parent=projects/*/locations/*/featur"
+ "eGroups/*}/features\022\204\002\n\rUpdateFeature\0225."
+ "google.cloud.aiplatform.v1beta1.UpdateFe"
+ "atureRequest\032\035.google.longrunning.Operat"
+ "ion\"\234\001\312A)\n\007Feature\022\036UpdateFeatureOperati"
+ "onMetadata\332A\023feature,update_mask\202\323\344\223\002T2I"
+ "/v1beta1/{feature.name=projects/*/locati"
+ "ons/*/featureGroups/*/features/*}:\007featu"
+ "re\022\353\001\n\rDeleteFeature\0225.google.cloud.aipl"
+ "atform.v1beta1.DeleteFeatureRequest\032\035.go"
+ "ogle.longrunning.Operation\"\203\001\312A0\n\025google"
+ ".protobuf.Empty\022\027DeleteOperationMetadata"
+ "\332A\004name\202\323\344\223\002C*A/v1beta1/{name=projects/*"
+ "/locations/*/featureGroups/*/features/*}"
+ "\032M\312A\031aiplatform.googleapis.com\322A.https:/"
+ "/www.googleapis.com/auth/cloud-platformB"
+ "\362\001\n#com.google.cloud.aiplatform.v1beta1B"
+ "\033FeatureRegistryServiceProtoP\001ZCcloud.go"
+ "ogle.com/go/aiplatform/apiv1beta1/aiplat"
+ "formpb;aiplatformpb\252\002\037Google.Cloud.AIPla"
+ "tform.V1Beta1\312\002\037Google\\Cloud\\AIPlatform\\"
+ "V1beta1\352\002\"Google::Cloud::AIPlatform::V1b"
+ "eta1b\006proto3"
};
descriptor =
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ service FeatureRegistryService {
option (google.api.method_signature) = "parent,feature,feature_id";
option (google.longrunning.operation_info) = {
response_type: "Feature"
metadata_type: "CreateRegistryFeatureOperationMetadata"
metadata_type: "CreateFeatureOperationMetadata"
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@

// [START aiplatform_v1beta1_generated_FeatureRegistryService_CreateFeature_LRO_async]
import com.google.api.gax.longrunning.OperationFuture;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.CreateFeatureRequest;
import com.google.cloud.aiplatform.v1beta1.CreateRegistryFeatureOperationMetadata;
import com.google.cloud.aiplatform.v1beta1.EntityTypeName;
import com.google.cloud.aiplatform.v1beta1.Feature;
import com.google.cloud.aiplatform.v1beta1.FeatureRegistryServiceClient;
Expand All @@ -46,7 +46,7 @@ public static void asyncCreateFeatureLRO() throws Exception {
.setFeature(Feature.newBuilder().build())
.setFeatureId("featureId-420503887")
.build();
OperationFuture<Feature, CreateRegistryFeatureOperationMetadata> future =
OperationFuture<Feature, CreateFeatureOperationMetadata> future =
featureRegistryServiceClient.createFeatureOperationCallable().futureCall(request);
// Do something.
Feature response = future.get();
Expand Down