Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add new aliasgen tool #6500

Merged
merged 13 commits into from
Aug 25, 2022
Merged

feat: add new aliasgen tool #6500

merged 13 commits into from
Aug 25, 2022

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 10, 2022

This tool is for an upcoming migration effort. We can use it to
make the migration quicker and less error prone.

@codyoss
feat: add new aliasgen tool
65c9ca1 
This tool is for an upcoming migration effort. We can use it to
make the migration quicker and less error prone.
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Aug 10, 2022
@codyoss codyoss marked this pull request as ready for review August 23, 2022 17:38
@codyoss codyoss requested a review from a team as a code owner August 23, 2022 17:38
noahdietz
noahdietz reviewed Aug 23, 2022
View reviewed changes
Copy link
Contributor

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is coooooool

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2022
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 24, 2022
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 24, 2022
@codyoss codyoss requested a review from noahdietz August 24, 2022 18:56
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 24, 2022
@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
@codyoss codyoss requested a review from quartzmo August 25, 2022 15:52
@codyoss codyoss requested a review from quartzmo August 25, 2022 17:30
@codyoss codyoss merged commit 279af69 into googleapis:main Aug 25, 2022
@codyoss codyoss deleted the aliasgen branch August 25, 2022 18:10
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@noahdietz noahdietz Awaiting requested review from noahdietz

Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codyoss @quartzmo @noahdietz