Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pubsub): Add ingestion from GCS topic creation sample #14749

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

michaelpri10
Copy link
Contributor

@michaelpri10 michaelpri10 commented Oct 1, 2024

Adds a sample for creating an ingestion from GCS import topic for Pub/Sub.


This change is Reviewable

@michaelpri10 michaelpri10 requested a review from a team as a code owner October 1, 2024 16:28
@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Oct 1, 2024
@scotthart
Copy link
Member

/gcbrun

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.41%. Comparing base (b0bac64) to head (5b249e2).
Report is 54 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/pubsub/samples/topic_admin_samples.cc 59.09% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14749      +/-   ##
==========================================
- Coverage   93.42%   93.41%   -0.02%     
==========================================
  Files        2315     2315              
  Lines      207681   207725      +44     
==========================================
+ Hits       194030   194043      +13     
- Misses      13651    13682      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @michaelpri10)

@scotthart scotthart merged commit 5eb47e8 into googleapis:main Oct 1, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants