fix: fix service account credentials createScopedRequired #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=========================================
Coverage 83.49% 83.49%
- Complexity 599 600 +1
=========================================
Files 42 42
Lines 2708 2709 +1
Branches 288 288
=========================================
+ Hits 2261 2262 +1
Misses 304 304
Partials 143 143
Continue to review full report at Codecov.
|
elharo
reviewed
Mar 18, 2021
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Outdated
Show resolved
Hide resolved
arithmetic1728
commented
Mar 18, 2021
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Outdated
Show resolved
Hide resolved
…dentialsTest.java
lesv
approved these changes
Mar 18, 2021
bshaffer
reviewed
Mar 18, 2021
| /** Returns whether the scopes are empty, meaning createScoped must be called before use. */ | ||
| @Override | ||
| public boolean createScopedRequired() { | ||
| return scopes.isEmpty(); |
There was a problem hiding this comment.
I think without having defaultScopes.isEmpty() here as well, the Client Library for Storage will never use self-signed JWTs. And there may be more APIs like this.
This can be fixed in a future PR, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: GoogleCloudPlatform/java-docs-samples#4907 (comment)