-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: adds integration tests for workload identity federation #581
Conversation
Tests fail on windows: Error: Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.052 s <<< FAILURE! - in com.google.auth.oauth2.ITWorkloadIdentityFederationTest Error: com.google.auth.oauth2.ITWorkloadIdentityFederationTest.awsCredentials Time elapsed: 0 s <<< ERROR! |
The windows and unit test failures are because these tests are integration tests that we only want to run in certain cases (need credentials and need to run on Kokoro). |
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
============================================
+ Coverage 83.45% 83.49% +0.04%
- Complexity 594 599 +5
============================================
Files 41 42 +1
Lines 2695 2708 +13
Branches 286 288 +2
============================================
+ Hits 2249 2261 +12
- Misses 303 304 +1
Partials 143 143
Continue to review full report at Codecov.
|
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ExternalAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ITWorkloadIdentityFederationTest.java
Outdated
Show resolved
Hide resolved
Warning: This pull request is touching the following templated files:
|
this.environmentProvider = SystemEnvironmentProvider.getInstance(); | ||
|
||
this.impersonatedCredentials = initializeImpersonatedCredentials(); | ||
this( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hindsight, we should have made these protected constructors accept only the Builders
to avoid bloating all these constructor overloads.
A setup script workloadidentityfederation-setup.sh is added to make the workload identity pool configuration changes on the current project, if needed. The setup script only needs to be run once on a project (already ran).