#492 id token from service account credential api #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h user credential. Print a warning to inform clearly the user on the behavior.
google-cla
bot
added
the
cla: yes
|
Hi Guillaume, Apologies for the delay in replying on this, I've had some very busy weeks :/ I've been talking to some of the other teams involved, and we want to support your use case but there is some work that we need to do to design some part of this in the larger context of enabling and simplifying sharing credentials across tools (e.g. CLI and client libraries). We've already started work on this, I'll keep you posted. |
|
@silvolu thanks you for your feedback. Let me know if I can help. It will be a pleasure. |
|
closing per @silvolu's comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492, Could replace the #469 which seems not accepted by @silvolu
Happy to discuss on this. The Env var name are important because this implementation could be reproduce in all other Google auth libraries (in other language) to have a unique way to add this env var (like today the
GOOGLE_APPLICATION_CREDENTIALSname)Best