Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Extensible Service Proxy #158

Closed
wants to merge 3 commits into from

Conversation

maguro
Copy link

@maguro maguro commented May 19, 2018

Cloud Endpoints' Extensible Service Proxy only takes JWTs, not access tokens. This
change provides the ability to trasform UserCredentials and ServiceAccountCredentals
such that they provide JWTs as bearer tokens.

CCLA is in the works. I thought I'd get the ball rolling with the review.

Cloud Endpoints' Extensible Service Proxy only takes JWTs, not access tokens.  This
change provides the ability to trasform UserCredentials and ServiceAccountCredentals
such that they provide JWTs as bearer tokens.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@maguro
Copy link
Author

maguro commented May 19, 2018

This PR is for #157.

@maguro
Copy link
Author

maguro commented May 20, 2018

I wonder if ServiceAccountCredentals needs to customize the forEsp() method since there's ServiceAccountJwtAccessCredentials.

@chingor13
Copy link
Contributor

Sorry for the delay in getting to this. Before we can review this PR, you'll need to sign one of CLA's mentioned above.

@chingor13
Copy link
Contributor

Closing as the CLA hasn't been signed yet so we can't look into the PR yet. Feel free to reopen when the CLA is signed.

@chingor13 chingor13 closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants