Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polly integration for HttpClient #1414

Closed
vova-lantsov-dev opened this issue Jun 15, 2019 · 4 comments · Fixed by #1528
Closed

Polly integration for HttpClient #1414

vova-lantsov-dev opened this issue Jun 15, 2019 · 4 comments · Fixed by #1528
Assignees
@chrisdunelm
Labels
type: question Request for information or clarification. Not an issue.

Comments

@vova-lantsov-dev
Copy link

I want to use retry policy for HttpClient created by Google.Apis.Http.HttpClientFactory, but this is a custom class and brings no support for such feature. Is there any workaround?
@jskeet jskeet added priority: p2 Moderately-important priority. Fix may not be included in next release. type: question Request for information or clarification. Not an issue. labels Jun 15, 2019
@chrisdunelm
Copy link
Contributor

@vova-lantsov-dev I'm not familiar with Polly. Please can you provide a code example of how you would like to use it, and show where/why this is not currently possible.

@vova-lantsov-dev
Copy link
Author

ConsoleApp1.zip
@chrisdunelm code comments included

@chrisdunelm
Copy link
Contributor

Thanks for the code example. I'll look at it in detail shortly.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Dec 12, 2019
@JustinBeckwith JustinBeckwith removed priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. labels Dec 16, 2019
jskeet added a commit to jskeet/google-api-dotnet-client that referenced this issue Mar 16, 2020
@jskeet
Move three issues to the backlog
34a59bd 
- Closes googleapis#1105
- Closes googleapis#1414
- Closes googleapis#1427
@jskeet jskeet mentioned this issue Mar 16, 2020
Merged
jskeet added a commit that referenced this issue Mar 16, 2020
@jskeet
Move three issues to the backlog
6893b6a 
- Closes #1105
- Closes #1414
- Closes #1427
amanda-tarafa added a commit that referenced this issue Mar 23, 2023
@amanda-tarafa
chore: Remove #1414 from the Backlog as obsolete
b0cb1bb 
We now support System.Net.Http.IHttpClientFactory which allows to configure HttpClient to use Polly among other things.
@amanda-tarafa
Copy link
Contributor

We now support System.Net.Http.IHttpClientFactory wich allows HttpClients to be configured to use Polly among other things. I've remove this issue from the BACKLOG as obsolete in #2371.

jskeet pushed a commit that referenced this issue Mar 23, 2023
@amanda-tarafa @jskeet
chore: Remove #1414 from the Backlog as obsolete
f921412 
We now support System.Net.Http.IHttpClientFactory which allows to configure HttpClient to use Polly among other things.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdunelm chrisdunelm

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move three issues to the backlog jskeet/google-api-dotnet-client
6 participants
@jskeet @chrisdunelm @JustinBeckwith @amanda-tarafa @yoshi-automation @vova-lantsov-dev