Skip to content
This repository has been archived by the owner on Mar 20, 2018. It is now read-only.

Roll new release with preference for new google-auth library. #140

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

bjwatson
Copy link
Contributor

@bjwatson bjwatson commented Nov 17, 2016

This still uses oauth2client by default, but will use
https://pypi.python.org/pypi/google-auth if installed.

Set upper bounds on dependencies to avoid future surprises.

FYI @jonparrott @dhermes

This still uses oauth2client by default, but will use
https://pypi.python.org/pypi/google-auth if installed.

Set upper bounds on dependencies to avoid future surprises.
@theacodes
Copy link

👍

@codecov-io
Copy link

Current coverage is 97.96% (diff: 100%)

Merging #140 into master will not change coverage

@@             master       #140   diff @@
==========================================
  Files             9          9          
  Lines           640        640          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            627        627          
  Misses           13         13          
  Partials          0          0          

Powered by Codecov. Last update 62170e4...8173dee

@geigerj
Copy link
Contributor

geigerj commented Nov 17, 2016

Note that we should not update the packman configuration until GAPIC has also been updated to use the new auth surface.

@bjwatson
Copy link
Contributor Author

@geigerj Do you see any problems with updating packman to use this version, as long as it does not add a google-auth dependency?

@geigerj
Copy link
Contributor

geigerj commented Nov 17, 2016

@bjwatson Yes, there's a problem -- #135 changed the public interface of GAX, so codegen needs some superficial updates before it can depend on GAX 0.15.0. I can do that tomorrow and then update packman if that works?

@bjwatson
Copy link
Contributor Author

SGTM

@bjwatson bjwatson merged commit a3a290a into googleapis:master Nov 17, 2016
@bjwatson bjwatson deleted the tighten-dependency-bounds branch November 17, 2016 00:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants