This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Python: use google.api.core.Operation for long running operations. #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
============================================
+ Coverage 86.92% 86.92% +<.01%
- Complexity 4112 4116 +4
============================================
Files 404 404
Lines 16575 16585 +10
Branches 1762 1764 +2
============================================
+ Hits 14407 14417 +10
Misses 1683 1683
Partials 485 485
Continue to review full report at Codecov.
|
| @@ -11,6 +11,7 @@ import sys | |||
|
|
|||
| install_requires = [ | |||
| 'google-auth>=1.0.2, <2.0dev', | |||
| 'google-cloud-core>=0.27.0, <1.0dev', | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
evaogbe
reviewed
Aug 24, 2017
| @@ -131,6 +131,9 @@ public boolean hasMissingDefaultOptions() { | |||
| @Nullable | |||
| public abstract String gapicPackageName(); | |||
|
|
|||
| @Nullable | |||
| public abstract List<String> operationTypes(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Aug 25, 2017
evaogbe
approved these changes
Aug 25, 2017
|
This is now obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates #1320
Here is the Operation class for reference:
https://github.com/GoogleCloudPlatform/google-cloud-python/blob/master/core/google/api/core/operation.py