Python: Introduced versioned api directory exporting types. #1368

landrito · 2017-06-16T23:56:28Z

Updates #1320

codecov-io · 2017-06-17T00:05:18Z

Codecov Report

Merging #1368 into master will increase coverage by 0.11%.
The diff coverage is 99.33%.

@@             Coverage Diff              @@
##             master    #1368      +/-   ##
============================================
+ Coverage     86.59%   86.71%   +0.11%     
- Complexity     3904     3942      +38     
============================================
  Files           382      383       +1     
  Lines         15632    15779     +147     
  Branches       1726     1736      +10     
============================================
+ Hits          13536    13682     +146     
- Misses         1634     1635       +1     
  Partials        462      462

Impacted Files	Coverage Δ	Complexity Δ
...en/viewmodel/metadata/VersionIndexRequireView.java	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
...i/codegen/viewmodel/metadata/VersionIndexView.java	`83.33% <ø> (ø)`	`4 <0> (ø)`	⬇️
...com/google/api/codegen/viewmodel/GrpcStubView.java	`100% <ø> (ø)`	`2 <0> (ø)`	⬇️
...om/google/api/codegen/util/py/PythonTypeTable.java	`89.85% <100%> (ø)`	`21 <1> (ø)`	⬇️
...e/api/codegen/transformer/GrpcStubTransformer.java	`100% <100%> (ø)`	`7 <0> (ø)`	⬇️
...api/codegen/transformer/py/PythonSurfaceNamer.java	`95.04% <100%> (+0.42%)`	`42 <3> (+2)`	⬆️
.../transformer/py/PythonGapicSurfaceTransformer.java	`100% <100%> (ø)`	`13 <13> (?)`
...le/api/codegen/gapic/MainGapicProviderFactory.java	`94.79% <100%> (+0.12%)`	`18 <0> (ø)`	⬇️
...transformer/py/PythonImportSectionTransformer.java	`96.44% <100%> (+2.05%)`	`47 <19> (+19)`	⬆️
...m/google/api/codegen/transformer/SurfaceNamer.java	`79% <85.71%> (+0.16%)`	`176 <4> (+4)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3356ff...d67b4de. Read the comment docs.

geigerj

Looks good overall, just nits/optionals/questions. Please have @lukesneeringer confirm the baseline files meet his expectations.

src/main/java/com/google/api/codegen/transformer/SurfaceNamer.java

@@ -159,6 +159,20 @@ public String getNamespace(Interface apiInterface) {
    return qualifiedName(namePath.withoutHead());
  }

+  /** The namespace of the package. */


src/main/java/com/google/api/codegen/transformer/SurfaceNamer.java

+  }
+
+  /** The name of a stub type of an interface */
+  public String getStubType(Interface apiInterface) {


src/main/java/com/google/api/codegen/transformer/py/PythonImportSectionTransformer.java

+    }
+  }
+
+  private Set<ProtoFile> getProtofileDependencies(Model model) {


src/main/java/com/google/api/codegen/transformer/py/PythonImportSectionTransformer.java

+    }
+
+    Set<ImportFileView> imports = new TreeSet<>(importFileViewComparator());
+    // TODO: (landrito) Make this only generate the enums module if there are enums to export.


src/main/java/com/google/api/codegen/transformer/py/PythonSurfaceNamer.java

@@ -146,8 +146,8 @@ public String getParseFunctionName(String var, SingleResourceNameConfig resource

  @Override
  public String getGrpcClientTypeName(Interface apiInterface) {
-    String fullName = getModelTypeFormatter().getFullNameFor(apiInterface) + "Stub";
-    return getTypeNameConverter().getTypeName(fullName).getNickname();
+    String fullName = getModelTypeFormatter().getFullNameFor(apiInterface) + "Client";


lukesneeringer

Just two actual issues, repeated throughout.

src/test/java/com/google/api/codegen/testdata/python_doc_types_library.baseline

+               wrappers_pb2
+               status_pb2):
+    for name, message in get_messages(module).items():
+        message.__module__ = 'google.cloud.proto.example.library_v1'


src/test/java/com/google/api/codegen/testdata/python_doc_types_no_path_templates.baseline

+               descriptor_pb2
+               empty_pb2):
+    for name, message in get_messages(module).items():
+        message.__module__ = 'google.cloud.proto.example_v1'


src/test/java/com/google/api/codegen/testdata/python_doc_types_library.baseline

@@ -0,0 +1,65 @@
+============== file: google/cloud/proto/example/library_v1/types.py ==============


src/test/java/com/google/api/codegen/testdata/python_doc_types_no_path_templates.baseline

@@ -0,0 +1,39 @@
+============== file: google/cloud/proto/example_v1/types.py ==============


...java/com/google/api/codegen/testdata/python_doc_versioned_directory__init___library.baseline

+from google.cloud.proto.example.library_v1 import types
+
+
+class LibraryServiceClient(LibraryHelpers, library_pb2.LibraryServiceClient):


...oogle/api/codegen/testdata/python_doc_versioned_directory__init___no_path_templates.baseline

+from google.cloud.proto.example_v1 import types
+
+
+class NoTemplatesAPIServiceClient(LibraryHelpers, no_path_templates_pb2.NoTemplatesAPIServiceClient):


src/test/java/com/google/api/codegen/testdata/python_types_library.baseline

@@ -0,0 +1,65 @@
+============== file: google/cloud/proto/example/library_v1/types.py ==============


landrito · 2017-08-14T17:12:49Z

Closing since this was done before the mvvm refactor. See new version of this at #1473.

Python: Introduced versioned api directory exporting types.

9b1c68b

landrito assigned lukesneeringer Jun 16, 2017

landrito requested review from lukesneeringer and geigerj June 16, 2017 23:56

geigerj reviewed Jun 29, 2017

View reviewed changes

Review fixes

d67b4de

lukesneeringer suggested changes Jun 30, 2017

View reviewed changes

landrito closed this Aug 14, 2017

landrito deleted the python-autogen-improvements branch September 24, 2018 19:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Python: Introduced versioned api directory exporting types. #1368

Python: Introduced versioned api directory exporting types. #1368

landrito commented Jun 16, 2017

codecov-io commented Jun 17, 2017 •

edited

Loading

geigerj left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

lukesneeringer left a comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

landrito commented Aug 14, 2017 •

edited

Loading

		@@ -0,0 +1,65 @@
		============== file: google/cloud/proto/example/library_v1/types.py ==============

		@@ -0,0 +1,39 @@
		============== file: google/cloud/proto/example_v1/types.py ==============

		from google.cloud.proto.example.library_v1 import types


		class LibraryServiceClient(LibraryHelpers, library_pb2.LibraryServiceClient):

		from google.cloud.proto.example_v1 import types


		class NoTemplatesAPIServiceClient(LibraryHelpers, no_path_templates_pb2.NoTemplatesAPIServiceClient):

Python: Introduced versioned api directory exporting types. #1368

Python: Introduced versioned api directory exporting types. #1368

Conversation

landrito commented Jun 16, 2017

codecov-io commented Jun 17, 2017 • edited Loading

Codecov Report

geigerj left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

lukesneeringer left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

landrito commented Aug 14, 2017 • edited Loading

codecov-io commented Jun 17, 2017 •

edited

Loading

landrito commented Aug 14, 2017 •

edited

Loading