Add Self: IntoBytes bound to TryFromBytes::try_mut*
#2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passing the edit token off to @joshlf for the |
joshlf
force-pushed
the
trytransmute-src-frombytes
branch
from
bbd15f8 to
25768c0
Compare
Done. |
joshlf
force-pushed
the
trytransmute-src-frombytes
branch
from
25768c0 to
e1c3f0f
Compare
joshlf
force-pushed
the
trytransmute-src-frombytes
branch
from
e1c3f0f to
67a2af8
Compare
joshlf
requested changes
Feb 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.8.x #2331 +/- ##
==========================================
+ Coverage 87.46% 87.48% +0.02%
==========================================
Files 16 16
Lines 6136 6162 +26
==========================================
+ Hits 5367 5391 +24
- Misses 769 771 +2 ☔ View full report in Codecov by Sentry. |
joshlf
approved these changes
Feb 14, 2025
|
Backporting in #2343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider that
MaybeUninit<u8>isTryFromBytes. If a&mut [u8]is cast into a&mut MaybeUninit<u8>, then uninit bytes are written, the shadowed&mut [u8]'s referent will no longer be valid.Makes progress towards #2226 and #1866.