Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a client that uses package:http #314

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

parlough
Copy link
Collaborator

@parlough parlough commented Feb 13, 2025

Then in a future release, the other clients can be deprecated in favor of this one.

@natebosch
Copy link
Member

The main concern at an initial glance is this will add http to the set of packages that are pinned by flutter. @devoncarew I think we should consider whether we are ok with this before getting in to a technical review.

@parlough can you share your motivation for this change?

@parlough
Copy link
Collaborator Author

parlough commented Mar 4, 2025

@parlough can you share your motivation for this change?

The motivation was to no longer require maintaining and choosing between two different clients and to follow the best practice we recommend of using package:http rather than relying on platform specifics.

I didn't realize Flutter pinned this package, but it seems it's only a dev dependency for flutter proper. It is a normal dependency for flutter_tools, but that seems to pin package:http already anyway.

It's also a dependency for flutter_driver, but I'm not sure if that would be a problem.

@natebosch
Copy link
Member

It's also a dependency for flutter_driver, but I'm not sure if that would be a problem.

It's still a problem for fllutter_driver. The scope of the problem is smaller than if it was a dep of flutter or flutter_test though. I'll see if I can get another opinion on how much of a problem it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants