add a result type #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
|
|
||
| @classmethod | ||
| def Result(cls, value): |
There was a problem hiding this comment.
Can we just have a result.Success or something semantic like that? AFAICT you never actually read the True values and True is just a placeholder.
|
LGTM apart from one comment on the |
|
Added. Starts fixing #74 |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A very simple implementation of a result type that wraps and returns exceptions from Message and Shell rather than reraising them. Tested manually by introducing errors to the example/* files and making sure the vroom output didn't change.
I believe this fixes all instances of reraising other than in the main Run loop.