Disabled python support in Bazel #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by an upstream change. We can only use master from repo because they don't have any tagged releases that are recent enough to build on a recognisable version of Bazel. Python support was changed in a recent commit upstream that breaks things for our usage. This is almost certainly fixable with enough time investigating, but AFAIK we have zero clients integrating by Bazel, and of this empty set, we know of zero Python users. Noted it in the CHANGELOG, and if anyone shouts we can prioritize.
AlCutter
approved these changes
Nov 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #1964 +/- ##
==========================================
+ Coverage 58.21% 58.25% +0.04%
==========================================
Files 117 117
Lines 9864 9864
==========================================
+ Hits 5742 5746 +4
+ Misses 3606 3602 -4
Partials 516 516
Continue to review full report at Codecov.
|
mhutchinson
added a commit
to mhutchinson/trillian
that referenced
this pull request
May 26, 2022
To our knowledge nobody was using this and python support was already removed in google#1964. If the removal of this affects anybody and they let us know, then I'm open to bringing this back. Without knowing it's used, this is something that breaks from time to time and demands investigation to keep CI working and thus hard to justify the return on investment. Fixes google#2690
mhutchinson
added a commit
that referenced
this pull request
May 26, 2022
To our knowledge nobody was using this and python support was already removed in #1964. If the removal of this affects anybody and they let us know, then I'm open to bringing this back. Without knowing it's used, this is something that breaks from time to time and demands investigation to keep CI working and thus hard to justify the return on investment. Fixes #2690
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by an upstream change. We can only use master from repo because they don't have any tagged releases that are recent enough to build on a recognisable version of Bazel. Python support was changed in a recent commit upstream that breaks things for our usage. This is almost certainly fixable with enough time investigating, but AFAIK we have zero clients integrating by Bazel, and of this empty set, we know of zero Python users. Noted it in the CHANGELOG, and if anyone shouts we can prioritize.