Add support for unknown fields in JSON serialization #49
Comments
osa1
added a commit
that referenced
this issue
Mar 4, 2024
…r generated accessors. (#918) Add support for unknown fields to JSON (de-)serialized proto messages. This allows data to be roundtripped from a server via this format without dropping fields when the client doesn't contain metadata for some fields. Store the data as decoded but unparsed json and append it back to the message when re-serializing a message. Ignore unknown json data for equality/hashing to preserve existing behavior for users. Taking this data into account would change the result of existing `==` and `hashCode` calls. By separating out `$_setField` and `$_clearField` this allows one to differentiate reflective uses of `setField` and `clearField` (i.e. from user code, usually with the result of `getTagNumber`) vs. internal uses from the generated accessors. Fixes #49. --- cl/611522109 cl/612283849 --------- Co-authored-by: Nate Biggs <natebiggs@google.com> Co-authored-by: Ömer Sinan Ağacan <omersa@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When reading and writing protobufs to JSON, we currently only serialize extensions if they are registered. Unknown fields are ignored.
This is a problem for the JSON-encoded constants for metadata in .pb.dart files. Any extensions in the original protobuf descriptor get stripped. It would be good to encode them somehow, instead.
The text was updated successfully, but these errors were encountered: