Remove use_magic_string_imports arg from J2wasm macros.

PiperOrigin-RevId: 728903218
google · Feb 20, 2025 · d21183e · d21183e
1 parent 7128668
commit d21183e
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/build_defs/internal_do_not_use/j2cl_test_common.bzl b/build_defs/internal_do_not_use/j2cl_test_common.bzl
@@ -171,7 +171,6 @@ def j2cl_test_common(
         compile = 0,
         platform = "CLOSURE",
         optimize_wasm = False,
-        use_magic_string_imports = False,
         wasm_defs = {},
         browsers = None,
         extra_defs = [],
@@ -255,7 +254,6 @@ def j2cl_test_common(
             deps = [":%s_testlib" % name],
             tags = tags,
             optimize = optimize_wasm,
-            use_magic_string_imports = use_magic_string_imports,
             defines = wasm_defs,
         )
 

diff --git a/build_defs/internal_do_not_use/j2wasm_application.bzl b/build_defs/internal_do_not_use/j2wasm_application.bzl
@@ -394,7 +394,7 @@ _J2WASM_APP_ATTRS = {
     # TODO(b/296477606): Remove when symbol map file can be linked from the binary for debugging.
     "enable_debug_info": attr.bool(default = False),
     "use_modular_pipeline": attr.bool(default = True),
-    "use_magic_string_imports": attr.bool(),
+    "use_magic_string_imports": attr.bool(default = False),
     "_jre": attr.label(default = Label("//build_defs/internal_do_not_use:j2wasm_jre")),
     "_j2cl_transpiler": attr.label(
         cfg = "exec",

diff --git a/build_defs/internal_do_not_use/j2wasm_generate_jsunit_suite.bzl b/build_defs/internal_do_not_use/j2wasm_generate_jsunit_suite.bzl
@@ -36,7 +36,6 @@ def j2wasm_generate_jsunit_suite(
         deps,
         tags = [],
         optimize = False,
-        use_magic_string_imports = False,
         defines = {}):
     """Macro for cross compiling a JUnit Suite to .wasm file.
 
@@ -99,7 +98,6 @@ def j2wasm_generate_jsunit_suite(
         ],
         testonly = 1,
         tags = tags + ["manual", "notap"],
-        use_magic_string_imports = use_magic_string_imports,
     )
 
     # Re-expose the target as "_dep" for test infra to depend on.