Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable pthreads on GTest project top-level when using MinGW #842

Closed
wants to merge 1 commit into from
Closed

Conversation

andoks
Copy link

@andoks andoks commented Aug 4, 2016

in commit a634042 "Implement threading
support for gtest on Windows", testing of internal threading in google
test does not work on MinGW. The commit itself contains a comment
indicating that pthreads is not to be used under MinGW due to

// On MinGW, we can have both GTEST_OS_WINDOWS and GTEST_HAS_PTHREAD
// defined, but we don't want to use MinGW's pthreads implementation which
// has conformance problems with some versions of the POSIX standard.

The first comment on #363 might indicate the reason for this breakage.

This commit assures that pthreads is disabled on a top-level by cmake

Fix #606

in commit a634042 "Implement threading
support for gtest on Windows", testing of internal threading in google
test does not work on MinGW. The commit itself contains a comment
indicating that pthreads is not to be used under MinGW due to

> // On MinGW, we can have both GTEST_OS_WINDOWS and GTEST_HAS_PTHREAD
> // defined, but we don't want to use MinGW's pthreads implementation which
> // has conformance problems with some versions of the POSIX standard.

The first comment on #363 might indicate the reason for this breakage.

This commit assures that pthreads is disabled on a top-level by cmake
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@KindDragon
Copy link
Contributor

What are the problems? Link maybe?

#606

@andoks
Copy link
Author

andoks commented Aug 5, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@andoks
Copy link
Author

andoks commented Aug 24, 2016

@BillyDonahue: is the explanation I gave earlier good enough for this PR to be merged, or do I need to do more changes?

It will fix #606 as the commit message states, while the bigger pr #721 will improve the windows implementation and fix the issue by avoiding pthreads on windows althogether as far as I can read.

@KindDragon
Copy link
Contributor

KindDragon commented Sep 1, 2016

PR #721 merged, so you can close your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants