Allow users to provide a templated overload of PrintTo #3682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently not possible to provide an overload of PrintTo for all the types supporting a specific concept
template<typename T, typename = std::enable_if_t<MatchesConcept<T>>>
void PrintTo(const T& t, std::ostream* os) {
// print using the concept
}
because this is as constrained as the fallback implementation defined in gtest, so the compiler considers them ambiguous.
With this change, gtest doesn't define a fallback implementation of PrintTo(), but instead checks if one is callable, and if it doesn't uses the fallback behaviour.
|
Closing as this is a simplification and results in currently working code not to compile. I opened another PR which has the fully backward compatible solution |
puetzk
added a commit
to puetzk/googletest
that referenced
this pull request
Sep 26, 2022
UnitTest::GetInstance()->original_working_dir() is documented public API: https://github.com/google/googletest/blob/main/docs/reference/testing.md#original_working_dir-unittestoriginal_working_dir and is used for things like UnitTestOptions::GetAbsolutePathToOutputFile. So stubbing it to just return an empty string breaks many other unit tests unnecessarily if you have a filesystem but not death tests If there's a need to do something special for diskless systems, seems like they should have a distinct check. reverts e5686bb google#3090 See google#3869 for discussion This has now been reverted (and refactored) on `main` by google#3682, but the refactoring is more complex than I want to cherry-pick. So we will keep the simple revert for 0.12.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently not possible to provide an overload of
PrintTofor all the types supporting a specific conceptbecause this is as constrained as the fallback implementation defined in gtest, so the compiler considers them ambiguous.
With this change, gtest doesn't define a fallback implementation of
PrintTo(), but instead checks if one is callable, and if it doesn't uses the fallback behaviour.This change addresses #3674 and it's largely backward compatible.
These are the situations in which this is not backward compatible
T, there is aPrintTofor typeQ,Tis convertible toQ.Before: fallback behaviours, After:
PrintTo(Q)There is a way to be fully backward compatible, but the implementation is more complicated (it involves simulating the old behaviour to detect whether the fallback or PrintTo would have been called), so I'm proposing this change first